2022-02-23 00:48:28

by Nícolas F. R. A. Prado

Subject: Re: [PATCH v2 14/23] arm64: dts: mt8192: Add mipi_tx node

On Fri, Feb 18, 2022 at 05:16:24PM +0800, Allen-KH Cheng wrote:
> Add mipi_tx node for mt8192 SoC.
>
> Signed-off-by: Allen-KH Cheng <[email protected]>
> ---
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index cfc2db501108..f5e5af949f19 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -1114,6 +1114,16 @@
> };
> };
>
> + mipi_tx0: mipi-dphy@11e50000 {

According to Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml, this
node's name should be dsi-phy, not mipi-dphy.

> + compatible = "mediatek,mt8183-mipi-tx";
> + reg = <0 0x11e50000 0 0x1000>;
> + clocks = <&apmixedsys CLK_APMIXED_MIPID26M>;
> + clock-names = "ref_clk";
> + #clock-cells = <0>;
> + #phy-cells = <0>;
> + clock-output-names = "mipi_tx0_pll";
> + };
> +
> i2c0: i2c@11f00000 {
> compatible = "mediatek,mt8192-i2c";
> reg = <0 0x11f00000 0 0x1000>,
> --
> 2.18.0
>
>

2022-02-26 01:37:09

by Nícolas F. R. A. Prado

Subject: Re: [PATCH v2 14/23] arm64: dts: mt8192: Add mipi_tx node

On Tue, Feb 22, 2022 at 04:27:03PM -0500, N?colas F. R. A. Prado wrote:
> On Fri, Feb 18, 2022 at 05:16:24PM +0800, Allen-KH Cheng wrote:
> > Add mipi_tx node for mt8192 SoC.
> >
> > Signed-off-by: Allen-KH Cheng <[email protected]>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > index cfc2db501108..f5e5af949f19 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > @@ -1114,6 +1114,16 @@
> > };
> > };
> >
> > + mipi_tx0: mipi-dphy@11e50000 {
>
> According to Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml, this
> node's name should be dsi-phy, not mipi-dphy.
>
> > + compatible = "mediatek,mt8183-mipi-tx";
> > + reg = <0 0x11e50000 0 0x1000>;
> > + clocks = <&apmixedsys CLK_APMIXED_MIPID26M>;
> > + clock-names = "ref_clk";

Also, this clock-names should be dropped [1].

[1] https://lore.kernel.org/all/CAAOTY_84OF71QK6M5JT1M5YAFKED_xWVpx8B8t859OsVxE0cfQ@mail.gmail.com/

> > + #clock-cells = <0>;
> > + #phy-cells = <0>;
> > + clock-output-names = "mipi_tx0_pll";
> > + };
> > +
> > i2c0: i2c@11f00000 {
> > compatible = "mediatek,mt8192-i2c";
> > reg = <0 0x11f00000 0 0x1000>,
> > --
> > 2.18.0
> >
> >