2022-03-02 08:31:24

by Yihao Han

[permalink] [raw]

Subject: [PATCH] power: supply: axp20x_usb_power: fix platform_get_irq.cocci warnings

---

Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Signed-off-by: Yihao Han <[email protected]>
---
drivers/power/supply/axp20x_usb_power.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c
index a1d110f7ddce..75170fe79cbf 100644
--- a/drivers/power/supply/axp20x_usb_power.c
+++ b/drivers/power/supply/axp20x_usb_power.c
@@ -638,8 +638,6 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
for (i = 0; i < axp_data->num_irq_names; i++) {
irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
if (irq < 0) {
- dev_err(&pdev->dev, "No IRQ for %s: %d\n",
- axp_data->irq_names[i], irq);
return irq;
}
power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);
--
2.17.1

2022-03-04 21:05:25

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: supply: axp20x_usb_power: fix platform_get_irq.cocci warnings

---

Hi,

On Tue, Mar 01, 2022 at 06:34:51PM -0800, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <[email protected]>
> ---

Thanks, queued (slightly modified to remove the now useless {}).

-- Sebastian

> drivers/power/supply/axp20x_usb_power.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c
> index a1d110f7ddce..75170fe79cbf 100644
> --- a/drivers/power/supply/axp20x_usb_power.c
> +++ b/drivers/power/supply/axp20x_usb_power.c
> @@ -638,8 +638,6 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
> for (i = 0; i < axp_data->num_irq_names; i++) {
> irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
> if (irq < 0) {
> - dev_err(&pdev->dev, "No IRQ for %s: %d\n",
> - axp_data->irq_names[i], irq);
> return irq;
> }
> power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);
> --
> 2.17.1
>

---

Attachments:

(No filename) (1.13 kB)
signature.asc (849.00 B)
Download all attachments