2022-03-02 20:50:10

by Colin Ian King

Subject: [PATCH] ALSA: echoaudio: remove redundant assignment to variable bytes

The variable bytes is being assigned a value that is never read, it
is being re-assigned inside a following if block. The assignment is
redundant and can be removed.

Cleans up clang scan build warning:
sound/pci/echoaudio/midi.c:211:9: warning: Although the value stored
to 'bytes' is used in the enclosing expression, the value is never
actually read from 'bytes' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
sound/pci/echoaudio/midi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/echoaudio/midi.c b/sound/pci/echoaudio/midi.c
index cb72d27e809e..7be5c3327b16 100644
--- a/sound/pci/echoaudio/midi.c
+++ b/sound/pci/echoaudio/midi.c
@@ -208,7 +208,7 @@ static void snd_echo_midi_output_write(struct timer_list *t)

/* No interrupts are involved: we have to check at regular intervals
if the card's output buffer has room for new data. */
- sent = bytes = 0;
+ sent = 0;
spin_lock_irqsave(&chip->lock, flags);
chip->midi_full = 0;
if (!snd_rawmidi_transmit_empty(chip->midi_out)) {
--
2.34.1

2022-03-04 13:31:25

by Takashi Iwai

Subject: Re: [PATCH] ALSA: echoaudio: remove redundant assignment to variable bytes

On Wed, 02 Mar 2022 18:07:28 +0100,
Colin Ian King wrote:
>
> The variable bytes is being assigned a value that is never read, it
> is being re-assigned inside a following if block. The assignment is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> sound/pci/echoaudio/midi.c:211:9: warning: Although the value stored
> to 'bytes' is used in the enclosing expression, the value is never
> actually read from 'bytes' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.


Takashi