2022-03-03 01:52:05

by CGEL

Subject: [PATCH] clk: Use of_device_get_match_data()

From: Minghao Chi (CGEL ZTE) <[email protected]>

Use of_device_get_match_data() to simplify the code.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi (CGEL ZTE) <[email protected]>
---
drivers/clk/clk-oxnas.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c
index 78d5ea669fea..cda5e258355b 100644
--- a/drivers/clk/clk-oxnas.c
+++ b/drivers/clk/clk-oxnas.c
@@ -209,15 +209,11 @@ static int oxnas_stdclk_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
const struct oxnas_stdclk_data *data;
- const struct of_device_id *id;
struct regmap *regmap;
int ret;
int i;

- id = of_match_device(oxnas_stdclk_dt_ids, &pdev->dev);
- if (!id)
- return -ENODEV;
- data = id->data;
+ data = of_device_get_match_data(&pdev->dev);

regmap = syscon_node_to_regmap(of_get_parent(np));
if (IS_ERR(regmap)) {
--
2.25.1

2022-03-03 08:24:17

by Neil Armstrong

Subject: Re: [PATCH] clk: Use of_device_get_match_data()

On 03/03/2022 02:48, [email protected] wrote:
> From: Minghao Chi (CGEL ZTE) <[email protected]>
>
> Use of_device_get_match_data() to simplify the code.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi (CGEL ZTE) <[email protected]>
> ---
> drivers/clk/clk-oxnas.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c
> index 78d5ea669fea..cda5e258355b 100644
> --- a/drivers/clk/clk-oxnas.c
> +++ b/drivers/clk/clk-oxnas.c
> @@ -209,15 +209,11 @@ static int oxnas_stdclk_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> const struct oxnas_stdclk_data *data;
> - const struct of_device_id *id;
> struct regmap *regmap;
> int ret;
> int i;
>
> - id = of_match_device(oxnas_stdclk_dt_ids, &pdev->dev);
> - if (!id)
> - return -ENODEV;
> - data = id->data;
> + data = of_device_get_match_data(&pdev->dev);
>
> regmap = syscon_node_to_regmap(of_get_parent(np));
> if (IS_ERR(regmap)) {


Acked-by: Neil Armstrong <[email protected]>

2022-03-12 14:21:25

by Stephen Boyd

Subject: Re: [PATCH] clk: Use of_device_get_match_data()

Quoting [email protected] (2022-03-02 17:48:56)
> From: Minghao Chi (CGEL ZTE) <[email protected]>
>
> Use of_device_get_match_data() to simplify the code.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi (CGEL ZTE) <[email protected]>
> ---

Applied to clk-next