2022-03-03 12:41:21

by Srinivas Kandagatla

Subject: [PATCH] soundwire: qcom: fix build failures if CONFIG_PM=n

Fix below build failure
drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
but not used [-Werror=unused-function]
by marking the resume swrm_runtime_resume() with __maybe_unused attribute.

Reported-by: Geert Uytterhoeven <[email protected]>
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Srinivas Kandagatla <[email protected]>
---
drivers/soundwire/qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index e893aee1b057..6575695cd400 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1459,7 +1459,7 @@ static bool swrm_wait_for_frame_gen_enabled(struct qcom_swrm_ctrl *swrm)
return false;
}

-static int swrm_runtime_resume(struct device *dev)
+static int __maybe_unused swrm_runtime_resume(struct device *dev)
{
struct qcom_swrm_ctrl *ctrl = dev_get_drvdata(dev);
int ret;
--
2.21.0

2022-03-03 16:28:38

by Vinod Koul

Subject: Re: [PATCH] soundwire: qcom: fix build failures if CONFIG_PM=n

On 03-03-22, 11:03, Srinivas Kandagatla wrote:
> Fix below build failure
> drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
> but not used [-Werror=unused-function]
> by marking the resume swrm_runtime_resume() with __maybe_unused attribute.

A patch title should reflect the change and not the cause. So i have
taken liberty to fix it as:

soundwire: qcom: use __maybe_unused for swrm_runtime_resume()

swrm_runtime_resume() would not be defined when CONFIG_PM=n

This causes below build failure
drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
but not used [-Werror=unused-function]

Mark the resume swrm_runtime_resume() with __maybe_unused attribute.

With this i have applied

--
~Vinod

2022-03-03 19:40:44

by Srinivas Kandagatla

Subject: Re: [PATCH] soundwire: qcom: fix build failures if CONFIG_PM=n

On 03/03/2022 15:55, Vinod Koul wrote:
> On 03-03-22, 11:03, Srinivas Kandagatla wrote:
>> Fix below build failure
>> drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
>> but not used [-Werror=unused-function]
>> by marking the resume swrm_runtime_resume() with __maybe_unused attribute.
>
> A patch title should reflect the change and not the cause. So i have
> taken liberty to fix it as:
>
> soundwire: qcom: use __maybe_unused for swrm_runtime_resume()
>
> swrm_runtime_resume() would not be defined when CONFIG_PM=n
>
> This causes below build failure
> drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
> but not used [-Werror=unused-function]
>
> Mark the resume swrm_runtime_resume() with __maybe_unused attribute.
>
> With this i have applied

Thanks Vinod,

--srini
>