2022-03-06 17:54:03

by Lianjie Zhang

Subject: [PATCH] mm/slub: helper macro __ATTR_XX to make code more clear

Signed-off-by: Lianjie Zhang <[email protected]>

diff --git a/mm/slub.c b/mm/slub.c
index 07cdd999c3fe..59992de7d3db 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -5358,12 +5358,10 @@ struct slab_attribute {
};

#define SLAB_ATTR_RO(_name) \
- static struct slab_attribute _name##_attr = \
- __ATTR(_name, 0400, _name##_show, NULL)
+ static struct slab_attribute _name##_attr = __ATTR_RO_MODE(_name, 0400)

#define SLAB_ATTR(_name) \
- static struct slab_attribute _name##_attr = \
- __ATTR(_name, 0600, _name##_show, _name##_store)
+ static struct slab_attribute _name##_attr = __ATTR_RW_MODE(_name, 0600)

static ssize_t slab_size_show(struct kmem_cache *s, char *buf)
{
--
2.20.1

2022-03-07 06:38:35

by David Rientjes

Subject: Re: [PATCH] mm/slub: helper macro __ATTR_XX to make code more clear

On Sun, 6 Mar 2022, Lianjie Zhang wrote:

> Signed-off-by: Lianjie Zhang <[email protected]>

And VERIFY_OCTAL_PERMISSIONS() can help validate any future change.

Acked-by: David Rientjes <[email protected]>

2022-03-07 18:24:15

by Vlastimil Babka

Subject: Re: [PATCH] mm/slub: helper macro __ATTR_XX to make code more clear

On 3/6/22 23:11, David Rientjes wrote:
> On Sun, 6 Mar 2022, Lianjie Zhang wrote:
>
>> Signed-off-by: Lianjie Zhang <[email protected]>
>
> And VERIFY_OCTAL_PERMISSIONS() can help validate any future change.
>
> Acked-by: David Rientjes <[email protected]>

Ok, adding with adjusted subject and non-empty message:

mm/slub: use helper macro __ATTR_XX_MODE for SLAB_ATTR(_RO)

This allows more concise code, and VERIFY_OCTAL_PERMISSIONS() can help
validate any future change.