2022-03-07 09:29:27

by Guo Zhengkui

Subject: [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD

Fix the following coccicheck warning:
drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
avoid newline at end of message in NL_SET_ERR_MSG_MOD

Signed-off-by: Guo Zhengkui <[email protected]>
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index 00a09b9e0aee..d5ff80a62882 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp,

if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) {
NL_SET_ERR_MSG_MOD(extack,
- "XSK buffer pool chunk size too small\n");
+ "XSK buffer pool chunk size too small");
return -EINVAL;
}
}
--
2.20.1

2022-03-07 10:06:47

by Niklas Söderlund

Subject: Re: [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD

Hi Guo,

Thanks for your work.

On 2022-03-07 17:07:59 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
>
> Signed-off-by: Guo Zhengkui <[email protected]>

Reviewed-by: Niklas S?derlund <[email protected]>

> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 00a09b9e0aee..d5ff80a62882 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp,
>
> if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) {
> NL_SET_ERR_MSG_MOD(extack,
> - "XSK buffer pool chunk size too small\n");
> + "XSK buffer pool chunk size too small");
> return -EINVAL;
> }
> }
> --
> 2.20.1
>

--
Regards,
Niklas S?derlund

2022-03-09 01:30:09

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Mon, 7 Mar 2022 17:07:59 +0800 you wrote:
> Fix the following coccicheck warning:
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
>
> Signed-off-by: Guo Zhengkui <[email protected]>
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD
https://git.kernel.org/netdev/net-next/c/0c1794c200e9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html