2022-03-07 20:53:42

by Leo Li

Subject: [PATCH] memory: fsl_ifc: populate child nodes of buses and mfd devices

Commit 98f1323959b8 was trying to replace the "simple-bus" compatible
with explicit bus populate in the driver. But of_platform_populate()
only populates child nodes of ifc without populating child buses and
child mfd devices residing under ifc. Change it to
of_platform_default_populate() to fix the problem.

Fixes: 98f1323959b8 ("memory: fsl_ifc: populate child devices without relying on simple-bus")

Signed-off-by: Li Yang <[email protected]>
---
drivers/memory/fsl_ifc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
index 6e6de52bb82d..1604de863d41 100644
--- a/drivers/memory/fsl_ifc.c
+++ b/drivers/memory/fsl_ifc.c
@@ -290,8 +290,7 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
}

/* legacy dts may still use "simple-bus" compatible */
- ret = of_platform_populate(dev->dev.of_node, NULL, NULL,
- &dev->dev);
+ ret = of_platform_default_populate(dev->dev.of_node, NULL, &dev->dev);
if (ret)
goto err_free_nandirq;

--
2.25.1

2022-03-17 09:47:48

by Krzysztof Kozlowski

Subject: Re: [PATCH] memory: fsl_ifc: populate child nodes of buses and mfd devices

On 07/03/2022 21:41, Li Yang wrote:
> Commit 98f1323959b8 was trying to replace the "simple-bus" compatible
> with explicit bus populate in the driver. But of_platform_populate()
> only populates child nodes of ifc without populating child buses and
> child mfd devices residing under ifc. Change it to
> of_platform_default_populate() to fix the problem.
>
> Fixes: 98f1323959b8 ("memory: fsl_ifc: populate child devices without relying on simple-bus")
>
> Signed-off-by: Li Yang <[email protected]>
> ---
> drivers/memory/fsl_ifc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

It's too late for upcoming cycle (patches after rc6 usually do not make
it), so I will pick it up after merge window.


Best regards,
Krzysztof

2022-04-06 14:30:38

by Krzysztof Kozlowski

Subject: Re: [PATCH] memory: fsl_ifc: populate child nodes of buses and mfd devices

On Mon, 7 Mar 2022 14:41:18 -0600, Li Yang wrote:
> Commit 98f1323959b8 was trying to replace the "simple-bus" compatible
> with explicit bus populate in the driver. But of_platform_populate()
> only populates child nodes of ifc without populating child buses and
> child mfd devices residing under ifc. Change it to
> of_platform_default_populate() to fix the problem.
>
> Fixes: 98f1323959b8 ("memory: fsl_ifc: populate child devices without relying on simple-bus")
>
> [...]

Applied, thanks!

[1/1] memory: fsl_ifc: populate child nodes of buses and mfd devices
commit: dd8adc713b1656ce469702eba8fc1adc4db91dc4

Best regards,
--
Krzysztof Kozlowski <[email protected]>