2022-03-08 16:20:08

by Qian Cai

Subject: [PATCH] configs/debug: Restore DEBUG_INFO=y for overriding

Previously, I failed to realize that Kees' patch [1] has not been merged
into the mainline yet, and dropped DEBUG_INFO=y too eagerly from the
mainline. As the results, "make debug.config" won't be able to flip
DEBUG_INFO=n from the existing .config. This should close the gaps of a
few weeks before Kees' patch is there, and work regardless of their
merging status anyway.

[1] https://lore.kernel.org/all/[email protected]/

Reported-by: Daniel Thompson <[email protected]>
Signed-off-by: Qian Cai <[email protected]>
---
kernel/configs/debug.config | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/configs/debug.config b/kernel/configs/debug.config
index 07df6d93c4df..e8db8d938661 100644
--- a/kernel/configs/debug.config
+++ b/kernel/configs/debug.config
@@ -16,6 +16,7 @@ CONFIG_SYMBOLIC_ERRNAME=y
#
# Compile-time checks and compiler options
#
+CONFIG_DEBUG_INFO=y
CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
CONFIG_DEBUG_SECTION_MISMATCH=y
CONFIG_FRAME_WARN=2048
--
2.30.2

2022-03-08 20:09:51

by Daniel Thompson

Subject: Re: [PATCH] configs/debug: Restore DEBUG_INFO=y for overriding

On Tue, Mar 08, 2022 at 10:35:24AM -0500, Qian Cai wrote:
> Previously, I failed to realize that Kees' patch [1] has not been merged
> into the mainline yet, and dropped DEBUG_INFO=y too eagerly from the
> mainline. As the results, "make debug.config" won't be able to flip
> DEBUG_INFO=n from the existing .config. This should close the gaps of a
> few weeks before Kees' patch is there, and work regardless of their
> merging status anyway.
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> Reported-by: Daniel Thompson <[email protected]>
> Signed-off-by: Qian Cai <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


Daniel.


> ---
> kernel/configs/debug.config | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/configs/debug.config b/kernel/configs/debug.config
> index 07df6d93c4df..e8db8d938661 100644
> --- a/kernel/configs/debug.config
> +++ b/kernel/configs/debug.config
> @@ -16,6 +16,7 @@ CONFIG_SYMBOLIC_ERRNAME=y
> #
> # Compile-time checks and compiler options
> #
> +CONFIG_DEBUG_INFO=y
> CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
> CONFIG_DEBUG_SECTION_MISMATCH=y
> CONFIG_FRAME_WARN=2048
> --
> 2.30.2
>

2022-03-10 15:10:59

by Andrew Morton

Subject: Re: [PATCH] configs/debug: Restore DEBUG_INFO=y for overriding

On Tue, 8 Mar 2022 10:35:24 -0500 Qian Cai <[email protected]> wrote:

> Previously, I failed to realize that Kees' patch [1] has not been merged
> into the mainline yet, and dropped DEBUG_INFO=y too eagerly from the
> mainline. As the results, "make debug.config" won't be able to flip
> DEBUG_INFO=n from the existing .config. This should close the gaps of a
> few weeks before Kees' patch is there, and work regardless of their
> merging status anyway.
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> ...
>
> --- a/kernel/configs/debug.config
> +++ b/kernel/configs/debug.config
> @@ -16,6 +16,7 @@ CONFIG_SYMBOLIC_ERRNAME=y
> #
> # Compile-time checks and compiler options
> #
> +CONFIG_DEBUG_INFO=y
> CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
> CONFIG_DEBUG_SECTION_MISMATCH=y
> CONFIG_FRAME_WARN=2048

Thanks, I queued this for 5.17,