2022-03-16 02:11:50

by Aleksander Jan Bajkowski

Subject: [PATCH net-next] net: lantiq_etop: add stats support

This patch adds support for software packet and byte counters.

Signed-off-by: Aleksander Jan Bajkowski <[email protected]>
---
drivers/net/ethernet/lantiq_etop.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 9b6fa27b7daf..9841551796f2 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -145,6 +145,8 @@ ltq_etop_hw_receive(struct ltq_etop_chan *ch)
skb_put(skb, len);
skb->protocol = eth_type_trans(skb, ch->netdev);
netif_receive_skb(skb);
+ ch->netdev->stats.rx_packets++;
+ ch->netdev->stats.rx_bytes += len;
}

static int
@@ -182,6 +184,8 @@ ltq_etop_poll_tx(struct napi_struct *napi, int budget)
spin_lock_irqsave(&priv->lock, flags);
while ((ch->dma.desc_base[ch->tx_free].ctl &
(LTQ_DMA_OWN | LTQ_DMA_C)) == LTQ_DMA_C) {
+ ch->netdev->stats.tx_packets++;
+ ch->netdev->stats.tx_bytes += ch->skb[ch->tx_free]->len;
dev_kfree_skb_any(ch->skb[ch->tx_free]);
ch->skb[ch->tx_free] = NULL;
memset(&ch->dma.desc_base[ch->tx_free], 0,
--
2.30.2

2022-03-17 05:28:03

by Jakub Kicinski

Subject: Re: [PATCH net-next] net: lantiq_etop: add stats support

On Wed, 16 Mar 2022 00:27:33 +0100 Aleksander Jan Bajkowski wrote:
> This patch adds support for software packet and byte counters.

On a quick look this driver supports multiple queues, so bumping
per-device stats without holding locks (on the rx side) seems racy.
Plus the netdev->stats are deprecated. The "modern" way of implementing
stats is to add the appropriate members to the ring / channel structure
and implement .ndo_get_stats64()