2022-03-17 19:02:32

by Horatiu Vultur

Subject: [PATCH net-next 1/5] dt-bindings: net: lan966x: Extend with FDMA interrupt

Extend dt-bindings for lan966x with FDMA interrupt. This is generated
when receiving a frame or when a frame was transmitted. The interrupt
needs to be enable for each frame.

Signed-off-by: Horatiu Vultur <[email protected]>
---
.../devicetree/bindings/net/microchip,lan966x-switch.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
index 13812768b923..14e0bae5965f 100644
--- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
+++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
@@ -39,6 +39,7 @@ properties:
- description: frame dma based extraction
- description: analyzer interrupt
- description: ptp interrupt
+ - description: fdma interrupt

interrupt-names:
minItems: 1
@@ -47,6 +48,7 @@ properties:
- const: fdma
- const: ana
- const: ptp
+ - const: fdma

resets:
items:
--
2.33.0

2022-03-18 07:05:00

by Michael Walle

Subject: Re: [PATCH net-next 1/5] dt-bindings: net: lan966x: Extend with FDMA interrupt

> Extend dt-bindings for lan966x with FDMA interrupt. This is generated
> when receiving a frame or when a frame was transmitted. The interrupt
> needs to be enable for each frame.
>
> Signed-off-by: Horatiu Vultur <[email protected]>
> ---
> .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> index 13812768b923..14e0bae5965f 100644
> --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> @@ -39,6 +39,7 @@ properties:
> - description: frame dma based extraction
> - description: analyzer interrupt
> - description: ptp interrupt
> + - description: fdma interrupt
>
> interrupt-names:
> minItems: 1
> @@ -47,6 +48,7 @@ properties:
> - const: fdma
> - const: ana
> - const: ptp
> + - const: fdma

This interrupt is already described (three lines above), no?

-michael

2022-03-18 10:41:27

by Horatiu Vultur

Subject: Re: [PATCH net-next 1/5] dt-bindings: net: lan966x: Extend with FDMA interrupt

The 03/18/2022 03:14, Michael Walle wrote:
>
> > Extend dt-bindings for lan966x with FDMA interrupt. This is generated
> > when receiving a frame or when a frame was transmitted. The interrupt
> > needs to be enable for each frame.
> >
> > Signed-off-by: Horatiu Vultur <[email protected]>
> > ---
> > .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > index 13812768b923..14e0bae5965f 100644
> > --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> > @@ -39,6 +39,7 @@ properties:
> > - description: frame dma based extraction
> > - description: analyzer interrupt
> > - description: ptp interrupt
> > + - description: fdma interrupt
> >
> > interrupt-names:
> > minItems: 1
> > @@ -47,6 +48,7 @@ properties:
> > - const: fdma
> > - const: ana
> > - const: ptp
> > + - const: fdma
>
> This interrupt is already described (three lines above), no?

Yes you are right.
So I will drop this patch in the next version.

>
> -michael

--
/Horatiu