2022-03-20 16:56:09

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER

On 3/18/22 16:30, Eduardo Valentin wrote:
> Add a thermal zone interface to the devices added
> under jc42 driver. This way, thermal zones described
> in device tree can make use of the of nodes of these
> devices.
>

Makes sense. I'll apply the patch, but it is a functional change
and a bit too risky to include in the upcoming commit window.
I'll apply it after the commit window closes.

Thanks,
Guenter

> Cc: Guenter Roeck <[email protected]> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
> Cc: Jean Delvare <[email protected]> (maintainer:HARDWARE MONITORING)
> Cc: [email protected] (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
> Cc: [email protected] (open list)
>
> Signed-off-by: Eduardo Valentin <[email protected]>
> Signed-off-by: Eduardo Valentin <[email protected]>
> ---
> drivers/hwmon/jc42.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> index cb347a6bd8d9..f40df2f29d41 100644
> --- a/drivers/hwmon/jc42.c
> +++ b/drivers/hwmon/jc42.c
> @@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
> }
>
> static const struct hwmon_channel_info *jc42_info[] = {
> + HWMON_CHANNEL_INFO(chip,
> + HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
> HWMON_CHANNEL_INFO(temp,
> HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
> HWMON_T_CRIT | HWMON_T_MAX_HYST |


2022-03-22 00:15:33

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER

On Sat, Mar 19, 2022 at 06:01:27PM -0700, Guenter Roeck wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On 3/18/22 16:30, Eduardo Valentin wrote:
> > Add a thermal zone interface to the devices added
> > under jc42 driver. This way, thermal zones described
> > in device tree can make use of the of nodes of these
> > devices.
> >
>
> Makes sense. I'll apply the patch, but it is a functional change
> and a bit too risky to include in the upcoming commit window.
> I'll apply it after the commit window closes.

Thank you Guenter. Yeah, this can go on the next window.

>
> Thanks,
> Guenter
>
> > Cc: Guenter Roeck <[email protected]> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
> > Cc: Jean Delvare <[email protected]> (maintainer:HARDWARE MONITORING)
> > Cc: [email protected] (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
> > Cc: [email protected] (open list)
> >
> > Signed-off-by: Eduardo Valentin <[email protected]>
> > Signed-off-by: Eduardo Valentin <[email protected]>
> > ---
> > drivers/hwmon/jc42.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> > index cb347a6bd8d9..f40df2f29d41 100644
> > --- a/drivers/hwmon/jc42.c
> > +++ b/drivers/hwmon/jc42.c
> > @@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
> > }
> >
> > static const struct hwmon_channel_info *jc42_info[] = {
> > + HWMON_CHANNEL_INFO(chip,
> > + HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
> > HWMON_CHANNEL_INFO(temp,
> > HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
> > HWMON_T_CRIT | HWMON_T_MAX_HYST |
>

--
All the best,
Eduardo Valentin