2022-03-25 17:46:05

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v3 17/26] clk: rk3399: use proper crypto0 name

Quoting LABBE Corentin (2022-03-25 00:40:22)
> Le Thu, Mar 24, 2022 at 05:41:23PM -0700, Stephen Boyd a écrit :
> > Quoting Corentin Labbe (2022-03-21 13:07:30)
> >
> > $ git grep SRST_CRYPTO
> > Documentation/devicetree/bindings/crypto/rockchip-crypto.txt: resets = <&cru SRST_CRYPTO>;
> > arch/arm/boot/dts/rk3288.dtsi: resets = <&cru SRST_CRYPTO>;
> >
> > Uh oh. Just don't change it and think about something else when it
> > starts to feel inconsistent.
>
> This is on rk3288, so not related to rk3399.
> Even on the RK3399 TRM, all crypto clocks are called either crypto0 or crypto1 (neither just crypto)
>

Ok. Please add a note in the commit text why it's OK to change the
define names.