2022-03-27 17:39:52

by Xiaomeng Tong

[permalink] [raw]
Subject: [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator

The bugs are here:
if (old_agg_vsi_info)
if (old_agg_vsi_info && !old_agg_vsi_info->tc_bitmap[0]) {

The list iterator value 'old_agg_vsi_info' will *always* be set
and non-NULL by list_for_each_entry_safe(), so it is incorrect
to assume that the iterator value will be NULL if the list is
empty or no element found (in this case, the check
'if (old_agg_vsi_info)' will always be true unexpectly).

To fix the bug, use a new variable 'iter' as the list iterator,
while use the original variable 'old_agg_vsi_info' as a dedicated
pointer to point to the found element.

Cc: [email protected]
Fixes: 37c592062b16d ("ice: remove the VSI info from previous agg")
Signed-off-by: Xiaomeng Tong <[email protected]>
---
drivers/net/ethernet/intel/ice/ice_sched.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_sched.c b/drivers/net/ethernet/intel/ice/ice_sched.c
index 7947223536e3..fba524148a09 100644
--- a/drivers/net/ethernet/intel/ice/ice_sched.c
+++ b/drivers/net/ethernet/intel/ice/ice_sched.c
@@ -2757,6 +2757,7 @@ ice_sched_assoc_vsi_to_agg(struct ice_port_info *pi, u32 agg_id,
u16 vsi_handle, unsigned long *tc_bitmap)
{
struct ice_sched_agg_vsi_info *agg_vsi_info, *old_agg_vsi_info = NULL;
+ struct ice_sched_agg_vsi_info *iter;
struct ice_sched_agg_info *agg_info, *old_agg_info;
struct ice_hw *hw = pi->hw;
int status = 0;
@@ -2774,11 +2775,13 @@ ice_sched_assoc_vsi_to_agg(struct ice_port_info *pi, u32 agg_id,
if (old_agg_info && old_agg_info != agg_info) {
struct ice_sched_agg_vsi_info *vtmp;

- list_for_each_entry_safe(old_agg_vsi_info, vtmp,
+ list_for_each_entry_safe(iter, vtmp,
&old_agg_info->agg_vsi_list,
list_entry)
- if (old_agg_vsi_info->vsi_handle == vsi_handle)
+ if (iter->vsi_handle == vsi_handle) {
+ old_agg_vsi_info = iter;
break;
+ }
}

/* check if entry already exist */
--
2.17.1


2022-03-28 22:49:22

by Jacob Keller

[permalink] [raw]
Subject: RE: [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator



> -----Original Message-----
> From: Xiaomeng Tong <[email protected]>
> Sent: Saturday, March 26, 2022 11:44 PM
> To: Brandeburg, Jesse <[email protected]>
> Cc: Nguyen, Anthony L <[email protected]>; [email protected];
> [email protected]; [email protected]; Raj, Victor <[email protected]>; intel-
> [email protected]; [email protected]; linux-
> [email protected]; Xiaomeng Tong <[email protected]>;
> [email protected]
> Subject: [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator
>
> The bugs are here:
> if (old_agg_vsi_info)
> if (old_agg_vsi_info && !old_agg_vsi_info->tc_bitmap[0]) {
>
> The list iterator value 'old_agg_vsi_info' will *always* be set
> and non-NULL by list_for_each_entry_safe(), so it is incorrect
> to assume that the iterator value will be NULL if the list is
> empty or no element found (in this case, the check
> 'if (old_agg_vsi_info)' will always be true unexpectly).
>
> To fix the bug, use a new variable 'iter' as the list iterator,
> while use the original variable 'old_agg_vsi_info' as a dedicated
> pointer to point to the found element.
>

Yep. This looks correct to me.

Reviewed-by: Jacob Keller <[email protected]>

Thanks,
Jake

> Cc: [email protected]
> Fixes: 37c592062b16d ("ice: remove the VSI info from previous agg")
> Signed-off-by: Xiaomeng Tong <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_sched.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_sched.c
> b/drivers/net/ethernet/intel/ice/ice_sched.c
> index 7947223536e3..fba524148a09 100644
> --- a/drivers/net/ethernet/intel/ice/ice_sched.c
> +++ b/drivers/net/ethernet/intel/ice/ice_sched.c
> @@ -2757,6 +2757,7 @@ ice_sched_assoc_vsi_to_agg(struct ice_port_info *pi,
> u32 agg_id,
> u16 vsi_handle, unsigned long *tc_bitmap)
> {
> struct ice_sched_agg_vsi_info *agg_vsi_info, *old_agg_vsi_info = NULL;
> + struct ice_sched_agg_vsi_info *iter;
> struct ice_sched_agg_info *agg_info, *old_agg_info;
> struct ice_hw *hw = pi->hw;
> int status = 0;
> @@ -2774,11 +2775,13 @@ ice_sched_assoc_vsi_to_agg(struct ice_port_info
> *pi, u32 agg_id,
> if (old_agg_info && old_agg_info != agg_info) {
> struct ice_sched_agg_vsi_info *vtmp;
>
> - list_for_each_entry_safe(old_agg_vsi_info, vtmp,
> + list_for_each_entry_safe(iter, vtmp,
> &old_agg_info->agg_vsi_list,
> list_entry)
> - if (old_agg_vsi_info->vsi_handle == vsi_handle)
> + if (iter->vsi_handle == vsi_handle) {
> + old_agg_vsi_info = iter;
> break;
> + }
> }
>
> /* check if entry already exist */
> --
> 2.17.1

2022-05-03 00:01:28

by G, GurucharanX

[permalink] [raw]
Subject: RE: [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator



-----Original Message-----
> From: Xiaomeng Tong <[email protected]>
> Sent: Saturday, March 26, 2022 11:44 PM
> To: Brandeburg, Jesse <[email protected]>
> Cc: Nguyen, Anthony L <[email protected]>;
> [email protected]; [email protected]; [email protected]; Raj, Victor
> <[email protected]>; intel- [email protected];
> [email protected]; linux- [email protected]; Xiaomeng Tong
> <[email protected]>; [email protected]
> Subject: [PATCH] ice: ice_sched: fix an incorrect NULL check on list
> iterator
>
> The bugs are here:
> if (old_agg_vsi_info)
> if (old_agg_vsi_info && !old_agg_vsi_info->tc_bitmap[0]) {
>
> The list iterator value 'old_agg_vsi_info' will *always* be set and
> non-NULL by list_for_each_entry_safe(), so it is incorrect to assume
> that the iterator value will be NULL if the list is empty or no
> element found (in this case, the check 'if (old_agg_vsi_info)' will
> always be true unexpectly).
>
> To fix the bug, use a new variable 'iter' as the list iterator, while
> use the original variable 'old_agg_vsi_info' as a dedicated pointer to
> point to the found element.
>

Yep. This looks correct to me.

> Reviewed-by: Jacob Keller <[email protected]>
>
> Thanks,
> Jake

> Cc: [email protected]
> Fixes: 37c592062b16d ("ice: remove the VSI info from previous agg")
> Signed-off-by: Xiaomeng Tong <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_sched.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>

Tested-by: Gurucharan <[email protected]> (A Contingent worker at Intel)

2022-05-03 01:29:05

by Raj, Victor

[permalink] [raw]
Subject: RE: [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator

If the control comes down to the loop then surely the VSI is already part of an aggregator (old). The aggregator vsi list should have that VSI information. My understanding is that if control comes here then you always find a valid entry and matching handle here. If that doesn't happen then we need to debug. The fix is kind of masking this problem.

-Victor



-----Original Message-----
From: G, GurucharanX <[email protected]>
Sent: Monday, May 2, 2022 1:18 AM
To: Keller, Jacob E <[email protected]>; Xiaomeng Tong <[email protected]>; Brandeburg, Jesse <[email protected]>
Cc: [email protected]; Raj, Victor <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [PATCH] ice: ice_sched: fix an incorrect NULL check on list iterator



-----Original Message-----
> From: Xiaomeng Tong <[email protected]>
> Sent: Saturday, March 26, 2022 11:44 PM
> To: Brandeburg, Jesse <[email protected]>
> Cc: Nguyen, Anthony L <[email protected]>;
> [email protected]; [email protected]; [email protected]; Raj, Victor
> <[email protected]>; intel- [email protected];
> [email protected]; linux- [email protected]; Xiaomeng Tong
> <[email protected]>; [email protected]
> Subject: [PATCH] ice: ice_sched: fix an incorrect NULL check on list
> iterator
>
> The bugs are here:
> if (old_agg_vsi_info)
> if (old_agg_vsi_info && !old_agg_vsi_info->tc_bitmap[0]) {
>
> The list iterator value 'old_agg_vsi_info' will *always* be set and
> non-NULL by list_for_each_entry_safe(), so it is incorrect to assume
> that the iterator value will be NULL if the list is empty or no
> element found (in this case, the check 'if (old_agg_vsi_info)' will
> always be true unexpectly).
>
> To fix the bug, use a new variable 'iter' as the list iterator, while
> use the original variable 'old_agg_vsi_info' as a dedicated pointer to
> point to the found element.
>

Yep. This looks correct to me.

> Reviewed-by: Jacob Keller <[email protected]>
>
> Thanks,
> Jake

> Cc: [email protected]
> Fixes: 37c592062b16d ("ice: remove the VSI info from previous agg")
> Signed-off-by: Xiaomeng Tong <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_sched.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>

Tested-by: Gurucharan <[email protected]> (A Contingent worker at Intel)