2022-03-28 22:36:59

by Xiubo Li

Subject: [PATCH v2] ceph: remove unused CEPH_MDS_LEASE_RELEASE related code

From: Xiubo Li <[email protected]>

ceph_mdsc_lease_release was removed by commit 8aa152c77890 (ceph:
remove ceph_mdsc_lease_release). ceph_mdsc_lease_send_msg will never
call this function with CEPH_MDS_LEASE_RELEASE.

Signed-off-by: Xiubo Li <[email protected]>
---
fs/ceph/mds_client.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index 459c6f23915f..a89ee866ebbb 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -4424,12 +4424,6 @@ void ceph_mdsc_lease_send_msg(struct ceph_mds_session *session,
memcpy((void *)(lease + 1) + 4,
dentry->d_name.name, dentry->d_name.len);
spin_unlock(&dentry->d_lock);
- /*
- * if this is a preemptive lease RELEASE, no need to
- * flush request stream, since the actual request will
- * soon follow.
- */
- msg->more_to_follow = (action == CEPH_MDS_LEASE_RELEASE);

ceph_con_send(&session->s_con, msg);
}
--
2.27.0

2022-03-28 23:05:28

by Jeff Layton

Subject: Re: [PATCH v2] ceph: remove unused CEPH_MDS_LEASE_RELEASE related code

On Mon, 2022-03-28 at 21:10 +0800, [email protected] wrote:
> From: Xiubo Li <[email protected]>
>
> ceph_mdsc_lease_release was removed by commit 8aa152c77890 (ceph:
> remove ceph_mdsc_lease_release). ceph_mdsc_lease_send_msg will never
> call this function with CEPH_MDS_LEASE_RELEASE.
>
> Signed-off-by: Xiubo Li <[email protected]>
> ---
> fs/ceph/mds_client.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 459c6f23915f..a89ee866ebbb 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -4424,12 +4424,6 @@ void ceph_mdsc_lease_send_msg(struct ceph_mds_session *session,
> memcpy((void *)(lease + 1) + 4,
> dentry->d_name.name, dentry->d_name.len);
> spin_unlock(&dentry->d_lock);
> - /*
> - * if this is a preemptive lease RELEASE, no need to
> - * flush request stream, since the actual request will
> - * soon follow.
> - */
> - msg->more_to_follow = (action == CEPH_MDS_LEASE_RELEASE);
>
> ceph_con_send(&session->s_con, msg);
> }

Reviewed-by: Jeff Layton <[email protected]>