2022-03-28 19:43:26

by Oscar Salvador

[permalink] [raw]
Subject: Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones

On Sun, Mar 27, 2022 at 02:41:00AM +0000, Wei Yang wrote:
> As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and
> reclaim from zones with pages managed by the buddy allocator") , reclaim
> only affects managed_zones.
>
> Let's adjust the code and comment accordingly.
>
> Signed-off-by: Wei Yang <[email protected]>

LGTM,

Reviewed-by: Oscar Salvador <[email protected]>

We still have some other places scattered all over where we use
populated_zone().
I think it should be great to check whether all those usages are
right.


--
Oscar Salvador
SUSE Labs


2022-03-29 01:01:51

by Wei Yang

[permalink] [raw]
Subject: Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones

On Mon, Mar 28, 2022 at 10:14:10AM +0200, Oscar Salvador wrote:
>On Sun, Mar 27, 2022 at 02:41:00AM +0000, Wei Yang wrote:
>> As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and
>> reclaim from zones with pages managed by the buddy allocator") , reclaim
>> only affects managed_zones.
>>
>> Let's adjust the code and comment accordingly.
>>
>> Signed-off-by: Wei Yang <[email protected]>
>
>LGTM,
>
>Reviewed-by: Oscar Salvador <[email protected]>
>
>We still have some other places scattered all over where we use
>populated_zone().
>I think it should be great to check whether all those usages are
>right.
>

Thanks.

This time I have checked vmscan related places, it looks all related part are
fixed. For others, I didn't get a chance to catch them.

>
>--
>Oscar Salvador
>SUSE Labs

--
Wei Yang
Help you, Help me