2022-03-30 23:49:43

by Austin Kim

Subject: [PATCH] arm: kdump: add invalid value check for 'crashkernel='

From: Austin Kim <[email protected]>

Add invalid value check expression when no crashkernel= or invalid value
specified using kdump.

Signed-off-by: Austin Kim <[email protected]>
---
arch/arm/kernel/setup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 039feb7cd590..8018d71ccaed 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -1004,7 +1004,8 @@ static void __init reserve_crashkernel(void)
total_mem = get_total_mem();
ret = parse_crashkernel(boot_command_line, total_mem,
&crash_size, &crash_base);
- if (ret)
+ /* no crashkernel= or invalid value specified */
+ if (ret || !crash_size)
return;

if (crash_base <= 0) {
--
2.20.1

2022-03-31 07:45:16

by Russell King (Oracle)

Subject: Re: [PATCH] arm: kdump: add invalid value check for 'crashkernel='

On Wed, Mar 30, 2022 at 12:07:15PM +0100, Austin Kim wrote:
> From: Austin Kim <[email protected]>
>
> Add invalid value check expression when no crashkernel= or invalid value
> specified using kdump.

Hi,

I think you mean when "crashkernel=0" is specified, as other invalid
input should result in -EINVAL being returned. Please update the
patch description and comment.

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2022-03-31 12:16:36

by Austin Kim

Subject: Re: [PATCH] arm: kdump: add invalid value check for 'crashkernel='

2022년 3월 31일 (목) 오후 4:10, Russell King (Oracle) <[email protected]>님이 작성:
>
> On Wed, Mar 30, 2022 at 12:07:15PM +0100, Austin Kim wrote:
> > From: Austin Kim <[email protected]>
> >
> > Add invalid value check expression when no crashkernel= or invalid value
> > specified using kdump.
>
> Hi,
>
> I think you mean when "crashkernel=0" is specified, as other invalid
> input should result in -EINVAL being returned. Please update the
> patch description and comment.

Thanks for feedback.
Let me resend the patch with updated commit description and comment soon.

BR,
Austin Kim

>
> Thanks.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!