Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: suspect code indent for conditional statements
Signed-off-by: Sevinj Aghayeva <[email protected]>
---
v1 -> v2: Remove the comments that became irrelevant with proper indentation.
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 04e29e228c1e..1bdbd0971f73 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -5143,17 +5143,9 @@ void link_timer_hdl(struct timer_list *t)
} else if (pmlmeinfo->state & WIFI_FW_AUTH_STATE) {
/* re-auth timer */
if (++pmlmeinfo->reauth_count > REAUTH_LIMIT) {
- /* if (pmlmeinfo->auth_algo != dot11AuthAlgrthm_Auto) */
- /* */
- pmlmeinfo->state = 0;
- report_join_res(padapter, -1);
- return;
- /* */
- /* else */
- /* */
- /* pmlmeinfo->auth_algo = dot11AuthAlgrthm_Shared; */
- /* pmlmeinfo->reauth_count = 0; */
- /* */
+ pmlmeinfo->state = 0;
+ report_join_res(padapter, -1);
+ return;
}
pmlmeinfo->auth_seq = 1;
--
2.25.1
On Tue, Apr 5, 2022 at 11:58 AM Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Tue, Apr 05, 2022 at 11:45:29AM -0400, Sevinj Aghayeva wrote:
> > On Tue, Apr 5, 2022 at 11:19 AM Sevinj Aghayeva
> > <[email protected]> wrote:
> > >
> > > On Tue, Apr 5, 2022 at 11:17 AM Greg Kroah-Hartman
> > > <[email protected]> wrote:
> > > >
> > > > On Tue, Apr 05, 2022 at 11:09:12AM -0400, Sevinj Aghayeva wrote:
> > > > > Adhere to Linux kernel coding style.
> > > > >
> > > > > Reported by checkpatch:
> > > > >
> > > > > WARNING: suspect code indent for conditional statements
> > > >
> > > > You are also removing unneeded comments, right? Please explain that as
> > > > the documentation link the bot pointed you to showed.
> > >
> > > I specified that under the --- line:
> > >
> > > v1 -> v2: Remove the comments that became irrelevant with proper indentation.
> >
> > I think I misunderstood the bot's response. It looks like you
> > triggered it because you wanted me to write a more complete
> > description of what the commit is doing. I thought I received it
> > because it was the second version of the patch from a previous
> > patchset (the last bullet point in the bot response) that didn't
> > include v2 in the subject and a v1 -> v2 after the --- line.
>
> That is one reason, yes, but you also need to update the changelog text
> to say everything you are doing in the commit.
Got it.
>
> > I can do a fresh patch with a complete description and no v2 stuff;
> > please let me know.
>
> It will be a v3 patch, right?
Right.
>
> thanks,
>
> greg k-h
--
Sevinj.Aghayeva