2022-04-06 17:29:18

by Alaa Mohamed

Subject: [PATCH] staging: rtl8712: remove Unnecessary parentheses

Reported by checkpatch:

CHECK: Unnecessary parentheses

Signed-off-by: Alaa Mohamed <[email protected]>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 3b6926613257..6c692ad7bde7 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *psta,
(param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len));
if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */
memcpy(psta->tkiptxmickey. skey,
- &(param->u.crypt.key[16]), 8);
+ &param->u.crypt.key[16], 8);
memcpy(psta->tkiprxmickey. skey,
- &(param->u.crypt.key[24]), 8);
+ &param->u.crypt.key[24], 8);
padapter->securitypriv. busetkipkey = false;
mod_timer(&padapter->securitypriv.tkip_timer,
jiffies + msecs_to_jiffies(50));
@@ -600,7 +600,7 @@ static int r8711_wx_get_name(struct net_device *dev,
u32 ht_ielen = 0;
char *p;
u8 ht_cap = false;
- struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
+ struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
u8 *prates;

@@ -1996,7 +1996,7 @@ static int r871x_get_ap_info(struct net_device *dev,
}
plist = plist->next;
}
- spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), irqL);
+ spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL);
if (pdata->length >= 34) {
if (copy_to_user((u8 __user *)pdata->pointer + 32,
(u8 *)&pdata->flags, 1))
--
2.35.1

2022-04-06 17:35:06

by Julia Lawall

Subject: Re: [PATCH] staging: rtl8712: remove Unnecessary parentheses

If you want to capitalize something in the subject, it could be the first
word. Capitalizing the second word is a bit strange.

On Wed, 6 Apr 2022, Alaa Mohamed wrote:

> Reported by checkpatch:
>
> CHECK: Unnecessary parentheses

Indicating that the problem was detected by checkpatch is good. But
actually, the parentheses all have the same property. So you could use
the log message to describe what kind of unnecessary parentheses were
removed. That would help the maintainer know what to look for.

julia

> Signed-off-by: Alaa Mohamed <[email protected]>
> ---
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 3b6926613257..6c692ad7bde7 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *psta,
> (param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len));
> if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */
> memcpy(psta->tkiptxmickey. skey,
> - &(param->u.crypt.key[16]), 8);
> + &param->u.crypt.key[16], 8);
> memcpy(psta->tkiprxmickey. skey,
> - &(param->u.crypt.key[24]), 8);
> + &param->u.crypt.key[24], 8);
> padapter->securitypriv. busetkipkey = false;
> mod_timer(&padapter->securitypriv.tkip_timer,
> jiffies + msecs_to_jiffies(50));
> @@ -600,7 +600,7 @@ static int r8711_wx_get_name(struct net_device *dev,
> u32 ht_ielen = 0;
> char *p;
> u8 ht_cap = false;
> - struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
> + struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
> struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
> u8 *prates;
>
> @@ -1996,7 +1996,7 @@ static int r871x_get_ap_info(struct net_device *dev,
> }
> plist = plist->next;
> }
> - spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), irqL);
> + spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL);
> if (pdata->length >= 34) {
> if (copy_to_user((u8 __user *)pdata->pointer + 32,
> (u8 *)&pdata->flags, 1))
> --
> 2.35.1
>
>
>

2022-04-06 19:24:47

by Joe Perches

Subject: Re: [PATCH] staging: rtl8712: remove Unnecessary parentheses

On Wed, 2022-04-06 at 17:37 +0200, Julia Lawall wrote:
> If you want to capitalize something in the subject, it could be the first
> word. Capitalizing the second word is a bit strange.
>
> On Wed, 6 Apr 2022, Alaa Mohamed wrote:
>
> > Reported by checkpatch:
> >
> > CHECK: Unnecessary parentheses
>
> Indicating that the problem was detected by checkpatch is good. But
> actually, the parentheses all have the same property. So you could use
> the log message to describe what kind of unnecessary parentheses were
> removed. That would help the maintainer know what to look for.
[]

> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
[]
> > @@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *psta,
> > (param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len));
> > if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */
> > memcpy(psta->tkiptxmickey. skey,

Also, the space after the periods here are not great either.

memcpy(psta->tkiptxmickey. skey,
vs
memcpy(psta->tkiptxmickey.skey,