2022-04-07 20:02:10

by Coco Li

Subject: [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig

XRFM is no longer needed for configuring FOU tunnels
(CONFIG_NET_FOU_IP_TUNNELS), remove from Kconfig.

Built and installed kernel and setup GUE/FOU tunnels.

Signed-off-by: Coco Li <[email protected]>
---
net/ipv4/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 87983e70f03f..e983bb0c5012 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -321,7 +321,6 @@ config NET_UDP_TUNNEL

config NET_FOU
tristate "IP: Foo (IP protocols) over UDP"
- select XFRM
select NET_UDP_TUNNEL
help
Foo over UDP allows any IP protocol to be directly encapsulated
--
2.35.1.1178.g4f1659d476-goog

2022-04-09 15:37:29

by Jakub Kicinski

Subject: Re: [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig

On Thu, 7 Apr 2022 10:15:54 -0700 Coco Li wrote:
> XRFM is no longer needed for configuring FOU tunnels
> (CONFIG_NET_FOU_IP_TUNNELS), remove from Kconfig.

What's the full story? The original code mentions udp_encap_rcv
but would be used to note where that dependency got removed.

> Built and installed kernel and setup GUE/FOU tunnels.
>
> Signed-off-by: Coco Li <[email protected]>
> ---
> net/ipv4/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 87983e70f03f..e983bb0c5012 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -321,7 +321,6 @@ config NET_UDP_TUNNEL
>
> config NET_FOU
> tristate "IP: Foo (IP protocols) over UDP"
> - select XFRM
> select NET_UDP_TUNNEL
> help
> Foo over UDP allows any IP protocol to be directly encapsulated

I think we can also remove the include of xfrm.h from fou.c ?