2022-04-08 12:28:37

by Kate Hsuan

Subject: [PATCH v3] staging: media: ipu3: Fix AWB x_start position when rightmost stripe is used

An not calibrated x_start setting would result in an incorrect AWB grid
configuration on a sensor when only the rightmost stripe is used.

If the AWB grid coordinate is set to the rightmost stripe, for example,
x_start is greater than 640, the AWB grid will be at the rightmost edge of
the sensor. The AWB statistic will be fetched from the wrong place of the
sensor and results in an incorrect AWB estimation result. Therefore,
stripe offset should subtract from x_start to have a correct grid
configuration for the rightmost stripe.

Signed-off-by: Kate Hsuan <[email protected]>
---
drivers/staging/media/ipu3/ipu3-css-params.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
index f84cf11358a8..76ad802d694e 100644
--- a/drivers/staging/media/ipu3/ipu3-css-params.c
+++ b/drivers/staging/media/ipu3/ipu3-css-params.c
@@ -2636,6 +2636,17 @@ int imgu_css_cfg_acc(struct imgu_css *css, unsigned int pipe,
acc->stripe.down_scaled_stripes[1].offset + min_overlap) {
/* Enable only for rightmost stripe, disable left */
acc->awb.stripes[0].rgbs_thr_b &= ~IPU3_UAPI_AWB_RGBS_THR_B_EN;
+
+ acc->awb.stripes[1].grid.x_start =
+ (acc->awb.stripes[1].grid.x_start -
+ acc->stripe.down_scaled_stripes[1].offset) &
+ IPU3_UAPI_GRID_START_MASK;
+
+ b_w_log2 = acc->awb.stripes[1].grid.block_width_log2;
+ acc->awb.stripes[1].grid.x_end =
+ imgu_css_grid_end(acc->awb.stripes[1].grid.x_start,
+ acc->awb.stripes[1].grid.width,
+ b_w_log2);
} else if (acc->awb.config.grid.x_end <=
acc->stripe.bds_out_stripes[0].width - min_overlap) {
/* Enable only for leftmost stripe, disable right */
--
2.35.1

2022-04-08 14:24:39

by Dan Carpenter

Subject: Re: [PATCH v3] staging: media: ipu3: Fix AWB x_start position when rightmost stripe is used

On Fri, Apr 08, 2022 at 06:42:22PM +0800, Kate Hsuan wrote:
> An not calibrated x_start setting would result in an incorrect AWB grid
> configuration on a sensor when only the rightmost stripe is used.
>
> If the AWB grid coordinate is set to the rightmost stripe, for example,
> x_start is greater than 640, the AWB grid will be at the rightmost edge of
> the sensor. The AWB statistic will be fetched from the wrong place of the
> sensor and results in an incorrect AWB estimation result. Therefore,
> stripe offset should subtract from x_start to have a correct grid
> configuration for the rightmost stripe.
>

Thank you!

regards,
dan carpenter