2022-04-12 21:32:19

by Herve Codina

Subject: [PATCH 3/6] PCI: rcar-gen2: Add R9A06G032 support

Add Renesas R9A06G032 SoC support to the Renesas R-Car gen2 PCI
bridge driver.
The Renesas RZ/N1D (R9A06G032) internal PCI bridge is compatible
with the one available in the R-Car Gen2 family.

Signed-off-by: Herve Codina <[email protected]>
---
drivers/pci/controller/pci-rcar-gen2.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
index 528bc3780e01..586e4785a57f 100644
--- a/drivers/pci/controller/pci-rcar-gen2.c
+++ b/drivers/pci/controller/pci-rcar-gen2.c
@@ -352,6 +352,8 @@ static const struct of_device_id rcar_pci_of_match[] = {
{ .compatible = "renesas,pci-r8a7791", },
{ .compatible = "renesas,pci-r8a7794", },
{ .compatible = "renesas,pci-rcar-gen2", },
+ { .compatible = "renesas,pci-r9a06g032", },
+ { .compatible = "renesas,pci-rzn1", },
{ },
};

--
2.35.1

2022-04-12 22:03:14

by Miquel Raynal

Subject: Re: [PATCH 3/6] PCI: rcar-gen2: Add R9A06G032 support

Hi Herve,

[email protected] wrote on Tue, 12 Apr 2022 11:40:26 +0200:

> Add Renesas R9A06G032 SoC support to the Renesas R-Car gen2 PCI
> bridge driver.
> The Renesas RZ/N1D (R9A06G032) internal PCI bridge is compatible
> with the one available in the R-Car Gen2 family.
>
> Signed-off-by: Herve Codina <[email protected]>
> ---
> drivers/pci/controller/pci-rcar-gen2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
> index 528bc3780e01..586e4785a57f 100644
> --- a/drivers/pci/controller/pci-rcar-gen2.c
> +++ b/drivers/pci/controller/pci-rcar-gen2.c
> @@ -352,6 +352,8 @@ static const struct of_device_id rcar_pci_of_match[] = {
> { .compatible = "renesas,pci-r8a7791", },
> { .compatible = "renesas,pci-r8a7794", },
> { .compatible = "renesas,pci-rcar-gen2", },
> + { .compatible = "renesas,pci-r9a06g032", },
> + { .compatible = "renesas,pci-rzn1", },

I don't think you don't yet need to match against the two, matching
against pci-rzn1 is enough for now, until we discover that something is
specific in the r9a06g032 family and we need to handle something else
of course.

Thanks,
Miquèl

2022-04-13 10:45:35

by Sergey Shtylyov

Subject: Re: [PATCH 3/6] PCI: rcar-gen2: Add R9A06G032 support

Hello!

On 4/12/22 12:40 PM, Herve Codina wrote:

> Add Renesas R9A06G032 SoC support to the Renesas R-Car gen2 PCI
> bridge driver.
> The Renesas RZ/N1D (R9A06G032) internal PCI bridge is compatible
> with the one available in the R-Car Gen2 family.
>
> Signed-off-by: Herve Codina <[email protected]>
> ---
> drivers/pci/controller/pci-rcar-gen2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
> index 528bc3780e01..586e4785a57f 100644
> --- a/drivers/pci/controller/pci-rcar-gen2.c
> +++ b/drivers/pci/controller/pci-rcar-gen2.c
> @@ -352,6 +352,8 @@ static const struct of_device_id rcar_pci_of_match[] = {
> { .compatible = "renesas,pci-r8a7791", },
> { .compatible = "renesas,pci-r8a7794", },
> { .compatible = "renesas,pci-rcar-gen2", },
> + { .compatible = "renesas,pci-r9a06g032", },

Do we really need this one here? Isn't it covered by the next item?

> + { .compatible = "renesas,pci-rzn1", },
> { },
> };
>

MBR, Sergey

2022-04-14 02:31:39

by Herve Codina

Subject: Re: [PATCH 3/6] PCI: rcar-gen2: Add R9A06G032 support

Hi Sergey,

On Wed, 13 Apr 2022 12:08:01 +0300
Sergey Shtylyov <[email protected]> wrote:

> Hello!
>
> On 4/12/22 12:40 PM, Herve Codina wrote:
>
> > Add Renesas R9A06G032 SoC support to the Renesas R-Car gen2 PCI
> > bridge driver.
> > The Renesas RZ/N1D (R9A06G032) internal PCI bridge is compatible
> > with the one available in the R-Car Gen2 family.
> >
> > Signed-off-by: Herve Codina <[email protected]>
> > ---
> > drivers/pci/controller/pci-rcar-gen2.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
> > index 528bc3780e01..586e4785a57f 100644
> > --- a/drivers/pci/controller/pci-rcar-gen2.c
> > +++ b/drivers/pci/controller/pci-rcar-gen2.c
> > @@ -352,6 +352,8 @@ static const struct of_device_id rcar_pci_of_match[] = {
> > { .compatible = "renesas,pci-r8a7791", },
> > { .compatible = "renesas,pci-r8a7794", },
> > { .compatible = "renesas,pci-rcar-gen2", },
> > + { .compatible = "renesas,pci-r9a06g032", },
>
> Do we really need this one here? Isn't it covered by the next item?

Yes, this one is not needed.
Miquèl did the same remark too.

I will remove '.compatible = "renesas,pci-r9a06g032"' in v2.

Regards,
Herve

>
> > + { .compatible = "renesas,pci-rzn1", },
> > { },
> > };
> >
>