2022-04-13 17:01:28

by Ahmad Fatoum

Subject: Re: [PATCH v3] arm64: dts: imx8mm-evk: add pwm1/backlight support

Hello Tomasso,

On 13.04.22 18:08, Tommaso Merciai wrote:
> Add pwm1/backlight support nodes for imx8mm_evk board.
> Align with u-boot dts
>
> References:
> - https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
>
> Signed-off-by: Tommaso Merciai <[email protected]>
> ---
> Changes since v1:
> - Fix commit body
> - Enable pwm, backlight
>
> Changes since v2:
> - Remove status okay from pwm1,backlight (enable as default)
>
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index 6d67df7692f1..c50d2cc3ca71 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> enable-active-high;
> };
>
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&pwm1 0 5000000>;
> + brightness-levels = <0 255>;
> + num-interpolated-steps = <255>;
> + default-brightness-level = <250>;
> + };
> +
> ir-receiver {
> compatible = "gpio-ir-receiver";
> gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
> @@ -395,6 +403,11 @@ &wdog1 {
> status = "okay";
> };
>
> +&pwm1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_backlight>;

imx8mm.dtsi has &pwm1 { status = "disabled" };
Where is it enabled?

> +};
> +
> &iomuxc {
> pinctrl_fec1: fec1grp {
> fsl,pins = <
> @@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp {
> MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
> >;
> };
> +
> + pinctrl_backlight: backlightgrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06
> + >;
> + };
> };


--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2022-04-14 13:43:54

by Tommaso Merciai

Subject: Re: [PATCH v3] arm64: dts: imx8mm-evk: add pwm1/backlight support

On Wed, Apr 13, 2022 at 06:31:34PM +0200, Ahmad Fatoum wrote:
> Hello Tomasso,
>
> On 13.04.22 18:08, Tommaso Merciai wrote:
> > Add pwm1/backlight support nodes for imx8mm_evk board.
> > Align with u-boot dts
> >
> > References:
> > - https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
> >
> > Signed-off-by: Tommaso Merciai <[email protected]>
> > ---
> > Changes since v1:
> > - Fix commit body
> > - Enable pwm, backlight
> >
> > Changes since v2:
> > - Remove status okay from pwm1,backlight (enable as default)
> >
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > index 6d67df7692f1..c50d2cc3ca71 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > @@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> > enable-active-high;
> > };
> >
> > + backlight: backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm1 0 5000000>;
> > + brightness-levels = <0 255>;
> > + num-interpolated-steps = <255>;
> > + default-brightness-level = <250>;
> > + };
> > +
> > ir-receiver {
> > compatible = "gpio-ir-receiver";
> > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
> > @@ -395,6 +403,11 @@ &wdog1 {
> > status = "okay";
> > };
> >
> > +&pwm1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_backlight>;
>
> imx8mm.dtsi has &pwm1 { status = "disabled" };
> Where is it enabled?

Hi Ahmad,
Thanks for review, update in v4.

Tommaso
>
> > +};
> > +
> > &iomuxc {
> > pinctrl_fec1: fec1grp {
> > fsl,pins = <
> > @@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp {
> > MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
> > >;
> > };
> > +
> > + pinctrl_backlight: backlightgrp {
> > + fsl,pins = <
> > + MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06
> > + >;
> > + };
> > };
>
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

--
Tommaso Merciai
Embedded Linux Engineer
[email protected]
__________________________________

Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
[email protected]
http://www.amarulasolutions.com