2022-04-18 14:47:27

by CGEL

Subject: [PATCH] hwspinlock: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

From: Minghao Chi <[email protected]>

Using pm_runtime_resume_and_get is more appropriate
for simplifing code

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/hwspinlock/omap_hwspinlock.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c
index 33eeff94fc2a..1fb3a2550e29 100644
--- a/drivers/hwspinlock/omap_hwspinlock.c
+++ b/drivers/hwspinlock/omap_hwspinlock.c
@@ -94,11 +94,9 @@ static int omap_hwspinlock_probe(struct platform_device *pdev)
* the module SYSSTATUS register
*/
pm_runtime_enable(&pdev->dev);
- ret = pm_runtime_get_sync(&pdev->dev);
- if (ret < 0) {
- pm_runtime_put_noidle(&pdev->dev);
+ ret = pm_runtime_resume_and_get(&pdev->dev);
+ if (ret < 0)
goto runtime_err;
- }

/* Determine number of locks */
i = readl(io_base + SYSSTATUS_OFFSET);
--
2.25.1

2022-04-23 12:51:15

by Bjorn Andersson

Subject: Re: (subset) [PATCH] hwspinlock: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

On Mon, 18 Apr 2022 10:55:08 +0000, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
>
>

Applied, thanks!

[1/1] hwspinlock: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
commit: 0e01d176d5788f66dc64a7e61119edb56eb08339

Best regards,
--
Bjorn Andersson <[email protected]>