LinuxLists.cc - [PATCH] clk: using pm_runtime_resume_and_get instead of pm_runtime_get

2022-04-18 12:27:25

Subject: [PATCH] clk: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

From: Minghao Chi <[email protected]>

Using pm_runtime_resume_and_get is more appropriate
for simplifing code

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/clk/clk.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ed119182aa1b..544e940bf40b 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -113,12 +113,8 @@ static int clk_pm_runtime_get(struct clk_core *core)
if (!core->rpm_enabled)
return 0;

- ret = pm_runtime_get_sync(core->dev);
- if (ret < 0) {
- pm_runtime_put_noidle(core->dev);
- return ret;
- }
- return 0;
+ ret = pm_runtime_resume_and_get(core->dev);
+ return ret;
}

static void clk_pm_runtime_put(struct clk_core *core)
--
2.25.1

2022-04-23 02:15:06

by Stephen Boyd

[permalink] [raw]

Subject: Re: [PATCH] clk: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

Quoting [email protected] (2022-04-18 04:04:55)
> From: Minghao Chi <[email protected]>
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/clk/clk.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index ed119182aa1b..544e940bf40b 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -113,12 +113,8 @@ static int clk_pm_runtime_get(struct clk_core *core)
> if (!core->rpm_enabled)
> return 0;
>
> - ret = pm_runtime_get_sync(core->dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(core->dev);
> - return ret;
> - }
> - return 0;
> + ret = pm_runtime_resume_and_get(core->dev);
> + return ret;

return pm_runtime_resume_and_get()

? I got it.

2022-04-23 02:16:01

by Stephen Boyd

[permalink] [raw]