2022-04-22 19:17:50

by Laxman Dewangan

Subject: [PATCH V1 1/1] scripts/Kbuild: Add path of fixeddep script

Add path of the fixdep script from the object tree.
This will make the path of script absolute rather than
relative and execute the command from makefile from any
location.

Signed-off-by: Laxman Dewangan <[email protected]>
---
scripts/Kbuild.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index cdec22088423e..e07e9265829f8 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -147,7 +147,7 @@ if_changed_dep = $(if $(if-changed-cond),$(cmd_and_fixdep),@:)

cmd_and_fixdep = \
$(cmd); \
- scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
+ $(objtree)/scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
rm -f $(depfile)

# Usage: $(call if_changed_rule,foo)
--
2.17.1

2022-04-22 22:46:18

by Masahiro Yamada

Subject: Re: [PATCH V1 1/1] scripts/Kbuild: Add path of fixeddep script

On Fri, Apr 22, 2022 at 6:05 PM Laxman Dewangan <[email protected]> wrote:
>
> Add path of the fixdep script from the object tree.
> This will make the path of script absolute rather than
> relative and execute the command from makefile from any
> location.



Why is this necessary?

Also, this patch does not make anything.
$(objtree)/ is still a relative path.
See the top Makefile.



>
> Signed-off-by: Laxman Dewangan <[email protected]>
> ---
> scripts/Kbuild.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index cdec22088423e..e07e9265829f8 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -147,7 +147,7 @@ if_changed_dep = $(if $(if-changed-cond),$(cmd_and_fixdep),@:)
>
> cmd_and_fixdep = \
> $(cmd); \
> - scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
> + $(objtree)/scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
> rm -f $(depfile)
>
> # Usage: $(call if_changed_rule,foo)
> --
> 2.17.1
>


--
Best Regards
Masahiro Yamada