From: Ethan Yang <[email protected]>
add support for Sierra Wireless EM7590 0xc080/0xc081 compositions
Signed-off-by: Ethan Yang <[email protected]>
---
drivers/usb/serial/qcserial.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index c18bf8164bc2..586ef5551e76 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -166,6 +166,8 @@ static const struct usb_device_id id_table[] = {
{DEVICE_SWI(0x1199, 0x9090)}, /* Sierra Wireless EM7565 QDL */
{DEVICE_SWI(0x1199, 0x9091)}, /* Sierra Wireless EM7565 */
{DEVICE_SWI(0x1199, 0x90d2)}, /* Sierra Wireless EM9191 QDL */
+ {DEVICE_SWI(0x1199, 0xc080)}, /* Sierra Wireless EM7590 QDL */
+ {DEVICE_SWI(0x1199, 0xc081)}, /* Sierra Wireless EM7590 */
{DEVICE_SWI(0x413c, 0x81a2)}, /* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
{DEVICE_SWI(0x413c, 0x81a3)}, /* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
{DEVICE_SWI(0x413c, 0x81a4)}, /* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */
--
2.17.1
Hi Johan,
Here is the change log:
To revise the correct composition for QDL/APP mode.
1199:c080 is for QDL, and 1199:c081 is for APP mode.
I also enclose the lsusb -v output for both compositions.
Thanks,
Ethan
-----Original Message-----
From: Johan Hovold <[email protected]>
Sent: Thursday, May 5, 2022 19:30
To: ???? ?? <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Glen Chiang <[email protected]>; Ethan Yang <[email protected]>
Subject: Re: [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590
On Mon, Apr 25, 2022 at 01:58:40PM +0800, [email protected] wrote:
> From: Ethan Yang <[email protected]>
>
> add support for Sierra Wireless EM7590 0xc080/0xc081 compositions
>
> Signed-off-by: Ethan Yang <[email protected]>
> ---
Please include a short changelog here (after the ---) when updating patches.
Please also include the output of usb-devices (or lsusb -v) for these two compositions for completeness.
Johan
On Thu, May 05, 2022 at 12:35:41PM +0000, Ethan Yang wrote:
> Hi Johan,
>
> Here is the change log:
> To revise the correct composition for QDL/APP mode.
> 1199:c080 is for QDL, and 1199:c081 is for APP mode.
I meant that when you when you resend a new version of a patch you
should include a changelog for what changed since the previous
version(s) (below the --- line).
In this case I think you only changed the From address from v1 to v2,
but I'm not sure.
No need to resend, but please keep that in mind for your future
submissions.
> I also enclose the lsusb -v output for both compositions.
Thanks a lot for that.
I've applied the patch now.
Johan
On Mon, Apr 25, 2022 at 01:58:40PM +0800, [email protected] wrote:
> From: Ethan Yang <[email protected]>
>
> add support for Sierra Wireless EM7590 0xc080/0xc081 compositions
>
> Signed-off-by: Ethan Yang <[email protected]>
> ---
Please include a short changelog here (after the ---) when updating
patches.
Please also include the output of usb-devices (or lsusb -v) for these
two compositions for completeness.
Johan