2022-04-25 16:01:10

by Arnaud Pouliquen

Subject: [PATCH] rpmsg: Fix parameter naming for announce_create/destroy ops.

The parameter associated to the announce_create and
announce_destroy ops functions is not an endpoint but a rpmsg device.

Signed-off-by: Arnaud Pouliquen <[email protected]>
---
No fixed sha1 indicated in commit message as issue is present since a
while, it does not fix a specific sha1.

git blame highlight the sha1 [1], but issue was present before.
The commit [1] just moves declaration from rpmsg.h to rpmsg_internal.

[1] fade037e0fd5 ("rpmsg: Hide rpmsg indirection tables")
---
drivers/rpmsg/rpmsg_internal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h
index d4b23fd019a8..ff0b12122235 100644
--- a/drivers/rpmsg/rpmsg_internal.h
+++ b/drivers/rpmsg/rpmsg_internal.h
@@ -41,8 +41,8 @@ struct rpmsg_device_ops {
rpmsg_rx_cb_t cb, void *priv,
struct rpmsg_channel_info chinfo);

- int (*announce_create)(struct rpmsg_device *ept);
- int (*announce_destroy)(struct rpmsg_device *ept);
+ int (*announce_create)(struct rpmsg_device *rpdev);
+ int (*announce_destroy)(struct rpmsg_device *rpdev);
};

/**
--
2.24.3

2022-06-24 17:29:06

by Mathieu Poirier

Subject: Re: [PATCH] rpmsg: Fix parameter naming for announce_create/destroy ops.

On Mon, Apr 25, 2022 at 09:17:23AM +0200, Arnaud Pouliquen wrote:
> The parameter associated to the announce_create and
> announce_destroy ops functions is not an endpoint but a rpmsg device.
>
> Signed-off-by: Arnaud Pouliquen <[email protected]>
> ---
> No fixed sha1 indicated in commit message as issue is present since a
> while, it does not fix a specific sha1.
>
> git blame highlight the sha1 [1], but issue was present before.
> The commit [1] just moves declaration from rpmsg.h to rpmsg_internal.
>
> [1] fade037e0fd5 ("rpmsg: Hide rpmsg indirection tables")

This patch is not a candidate for the stable kernel and as such a "Fixes" tag
isn't needed.

> ---
> drivers/rpmsg/rpmsg_internal.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h
> index d4b23fd019a8..ff0b12122235 100644
> --- a/drivers/rpmsg/rpmsg_internal.h
> +++ b/drivers/rpmsg/rpmsg_internal.h
> @@ -41,8 +41,8 @@ struct rpmsg_device_ops {
> rpmsg_rx_cb_t cb, void *priv,
> struct rpmsg_channel_info chinfo);
>
> - int (*announce_create)(struct rpmsg_device *ept);
> - int (*announce_destroy)(struct rpmsg_device *ept);
> + int (*announce_create)(struct rpmsg_device *rpdev);
> + int (*announce_destroy)(struct rpmsg_device *rpdev);

I have applied this patch.

Thanks,
Mathieu

> };
>
> /**
> --
> 2.24.3
>