Many of the stuff is reported by static analysis
changes are
- Update the copyright text
- Check the return valuesof runtime and clock enable calls
- Check the ignore_status in the isr
- Prevent writing to the fifo when controller is disabled.
Michal Simek (1):
xilinx: Update copyright text to correct format
Shubhrajyoti Datta (6):
tty: xilinx_uartps: Check the clk_enable return value
tty: xilinx_uartps: Add check for runtime_get_sync calls
tty: xilinx_uartps: Check clk_enable return type
tty: xilinx_uartps: Make the timeout unsigned
serial: uartps: Fix the ignore_status
serial: uartps: Prevent writes when the controller is disabled
drivers/tty/serial/xilinx_uartps.c | 45 ++++++++++++++++++++++++------
1 file changed, 37 insertions(+), 8 deletions(-)
--
2.25.1
From: Michal Simek <[email protected]>
Based on recommended guidance Copyright term should be also present in
front of (c). That's why aligned drivers to match this pattern.
It helps automated tools with source code scanning.
Signed-off-by: Michal Simek <[email protected]>
Signed-off-by: Shubhrajyoti Datta <[email protected]>
---
drivers/tty/serial/xilinx_uartps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 250a1d888eeb..fa82f88844a1 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -2,7 +2,7 @@
/*
* Cadence UART driver (found in Xilinx Zynq)
*
- * 2011 - 2014 (C) Xilinx Inc.
+ * Copyright (c) 2011 - 2014 Xilinx, Inc.
*
* This driver has originally been pushed by Xilinx using a Zynq-branding. This
* still shows in the naming of this file, the kconfig symbols and some symbols
--
2.25.1
On Fri, Apr 29, 2022 at 01:44:15PM +0530, Shubhrajyoti Datta wrote:
> Many of the stuff is reported by static analysis
> changes are
>
> - Update the copyright text
> - Check the return valuesof runtime and clock enable calls
> - Check the ignore_status in the isr
> - Prevent writing to the fifo when controller is disabled.
>
> Michal Simek (1):
> xilinx: Update copyright text to correct format
>
> Shubhrajyoti Datta (6):
> tty: xilinx_uartps: Check the clk_enable return value
> tty: xilinx_uartps: Add check for runtime_get_sync calls
> tty: xilinx_uartps: Check clk_enable return type
> tty: xilinx_uartps: Make the timeout unsigned
> serial: uartps: Fix the ignore_status
> serial: uartps: Prevent writes when the controller is disabled
Nit, why is the subject line prefix not unified here? Shouldn't they
all be "tty: xilinx_uartps:" like 4 of them are?
Can you fix up and resend?
thanks,
greg k-h
Hi Greg,
Thanks for the review.
> -----Original Message-----
> From: Greg KH <[email protected]>
> Sent: Friday, May 6, 2022 2:19 AM
> To: Shubhrajyoti Datta <[email protected]>
> Cc: [email protected]; Michal Simek <[email protected]>;
> [email protected]; git <[email protected]>; [email protected]
> Subject: Re: [PATCH 0/7] tty: xilinx_uartps: fixes and improvements
>
> On Fri, Apr 29, 2022 at 01:44:15PM +0530, Shubhrajyoti Datta wrote:
> > Many of the stuff is reported by static analysis changes are
> >
> > - Update the copyright text
> > - Check the return valuesof runtime and clock enable calls
> > - Check the ignore_status in the isr
> > - Prevent writing to the fifo when controller is disabled.
> >
> > Michal Simek (1):
> > xilinx: Update copyright text to correct format
> >
> > Shubhrajyoti Datta (6):
> > tty: xilinx_uartps: Check the clk_enable return value
> > tty: xilinx_uartps: Add check for runtime_get_sync calls
> > tty: xilinx_uartps: Check clk_enable return type
> > tty: xilinx_uartps: Make the timeout unsigned
> > serial: uartps: Fix the ignore_status
> > serial: uartps: Prevent writes when the controller is disabled
>
> Nit, why is the subject line prefix not unified here? Shouldn't they all be "tty:
> xilinx_uartps:" like 4 of them are?
>
> Can you fix up and resend?
I will fix up and resend in v2
>
> thanks,
>
> greg k-h