2022-04-29 15:14:00

by Matthias Brugger

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

From: Matthias Brugger <[email protected]>

The msdc gate is part of the MMC driver. Delete the binding description
of this node.

Signed-off-by: Matthias Brugger <[email protected]>

---

Changes in v2:
- Delete compatible in binding descprition as well

.../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
1 file changed, 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index c8c67c033f8c..b57cc2e69efb 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -24,7 +24,6 @@ properties:
- mediatek,mt8192-imp_iic_wrap_w
- mediatek,mt8192-imp_iic_wrap_n
- mediatek,mt8192-msdc_top
- - mediatek,mt8192-msdc
- mediatek,mt8192-mfgcfg
- mediatek,mt8192-imgsys
- mediatek,mt8192-imgsys2
@@ -107,13 +106,6 @@ examples:
#clock-cells = <1>;
};

- - |
- msdc: clock-controller@11f60000 {
- compatible = "mediatek,mt8192-msdc";
- reg = <0x11f60000 0x1000>;
- #clock-cells = <1>;
- };
-
- |
mfgcfg: clock-controller@13fbf000 {
compatible = "mediatek,mt8192-mfgcfg";
--
2.34.1


Subject: Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

Il 29/04/22 14:31, [email protected] ha scritto:
> From: Matthias Brugger <[email protected]>
>
> The msdc gate is part of the MMC driver. Delete the binding description
> of this node.
>
> Signed-off-by: Matthias Brugger <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2022-05-04 17:18:02

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

On Fri, Apr 29, 2022 at 02:31:31PM +0200, [email protected] wrote:
> From: Matthias Brugger <[email protected]>
>
> The msdc gate is part of the MMC driver. Delete the binding description
> of this node.

An ABI break is okay because ...?

> Signed-off-by: Matthias Brugger <[email protected]>
>
> ---
>
> Changes in v2:
> - Delete compatible in binding descprition as well
>
> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..b57cc2e69efb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -24,7 +24,6 @@ properties:
> - mediatek,mt8192-imp_iic_wrap_w
> - mediatek,mt8192-imp_iic_wrap_n
> - mediatek,mt8192-msdc_top
> - - mediatek,mt8192-msdc
> - mediatek,mt8192-mfgcfg
> - mediatek,mt8192-imgsys
> - mediatek,mt8192-imgsys2
> @@ -107,13 +106,6 @@ examples:
> #clock-cells = <1>;
> };
>
> - - |
> - msdc: clock-controller@11f60000 {
> - compatible = "mediatek,mt8192-msdc";
> - reg = <0x11f60000 0x1000>;
> - #clock-cells = <1>;
> - };
> -
> - |
> mfgcfg: clock-controller@13fbf000 {
> compatible = "mediatek,mt8192-mfgcfg";
> --
> 2.34.1
>
>

2022-05-05 20:11:51

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock



On 03/05/2022 23:48, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 02:31:31PM +0200, [email protected] wrote:
>> From: Matthias Brugger <[email protected]>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
>
> An ABI break is okay because ...?
>

Because the code controlling the clock gate was moved to the consumer. This node
did never ever represent any working implementation of a peripheral. Just a
lonely clock gate that wasn't used.

Regards,
Matthias

>> Signed-off-by: Matthias Brugger <[email protected]>
>>
>> ---
>>
>> Changes in v2:
>> - Delete compatible in binding descprition as well
>>
>> .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> index c8c67c033f8c..b57cc2e69efb 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> @@ -24,7 +24,6 @@ properties:
>> - mediatek,mt8192-imp_iic_wrap_w
>> - mediatek,mt8192-imp_iic_wrap_n
>> - mediatek,mt8192-msdc_top
>> - - mediatek,mt8192-msdc
>> - mediatek,mt8192-mfgcfg
>> - mediatek,mt8192-imgsys
>> - mediatek,mt8192-imgsys2
>> @@ -107,13 +106,6 @@ examples:
>> #clock-cells = <1>;
>> };
>>
>> - - |
>> - msdc: clock-controller@11f60000 {
>> - compatible = "mediatek,mt8192-msdc";
>> - reg = <0x11f60000 0x1000>;
>> - #clock-cells = <1>;
>> - };
>> -
>> - |
>> mfgcfg: clock-controller@13fbf000 {
>> compatible = "mediatek,mt8192-mfgcfg";
>> --
>> 2.34.1
>>
>>

2022-05-22 07:07:09

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

Quoting Matthias Brugger (2022-05-05 09:47:30)
>
>
> On 03/05/2022 23:48, Rob Herring wrote:
> > On Fri, Apr 29, 2022 at 02:31:31PM +0200, [email protected] wrote:
> >> From: Matthias Brugger <[email protected]>
> >>
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> >
> > An ABI break is okay because ...?
> >
>
> Because the code controlling the clock gate was moved to the consumer. This node
> did never ever represent any working implementation of a peripheral. Just a
> lonely clock gate that wasn't used.

Can you add that to the description and resend?