2022-04-04 12:11:50

by Michael Walle

Subject: [PATCH v4 3/4] dt-bindings: hwmon: add Microchip LAN966x bindings

Add a binding for the temperature sensor and the fan controller on the
Microchip LAN966x family.

Signed-off-by: Michael Walle <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/hwmon/microchip,lan966x.yaml | 53 +++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml b/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
new file mode 100644
index 000000000000..390dd6755ff5
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/microchip,lan966x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip LAN966x Hardware Monitor
+
+maintainers:
+ - Michael Walle <[email protected]>
+
+description: |
+ Microchip LAN966x temperature monitor and fan controller
+
+properties:
+ compatible:
+ enum:
+ - microchip,lan9668-hwmon
+
+ reg:
+ items:
+ - description: PVT registers
+ - description: FAN registers
+
+ reg-names:
+ items:
+ - const: pvt
+ - const: fan
+
+ clocks:
+ maxItems: 1
+
+ '#thermal-sensor-cells':
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ hwmon: hwmon@e2010180 {
+ compatible = "microchip,lan9668-hwmon";
+ reg = <0xe2010180 0xc>,
+ <0xe20042a8 0xc>;
+ reg-names = "pvt", "fan";
+ clocks = <&sys_clk>;
+ #thermal-sensor-cells = <0>;
+ };
--
2.30.2

2022-04-24 19:00:43

by Guenter Roeck

Subject: Re: [PATCH v4 3/4] dt-bindings: hwmon: add Microchip LAN966x bindings

On 4/1/22 14:40, Michael Walle wrote:
> Add a binding for the temperature sensor and the fan controller on the
> Microchip LAN966x family.
>
> Signed-off-by: Michael Walle <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Still needs approval by a devicetree maintainer.

Guenter

> ---
> .../bindings/hwmon/microchip,lan966x.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml b/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
> new file mode 100644
> index 000000000000..390dd6755ff5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/microchip,lan966x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN966x Hardware Monitor
> +
> +maintainers:
> + - Michael Walle <[email protected]>
> +
> +description: |
> + Microchip LAN966x temperature monitor and fan controller
> +
> +properties:
> + compatible:
> + enum:
> + - microchip,lan9668-hwmon
> +
> + reg:
> + items:
> + - description: PVT registers
> + - description: FAN registers
> +
> + reg-names:
> + items:
> + - const: pvt
> + - const: fan
> +
> + clocks:
> + maxItems: 1
> +
> + '#thermal-sensor-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + hwmon: hwmon@e2010180 {
> + compatible = "microchip,lan9668-hwmon";
> + reg = <0xe2010180 0xc>,
> + <0xe20042a8 0xc>;
> + reg-names = "pvt", "fan";
> + clocks = <&sys_clk>;
> + #thermal-sensor-cells = <0>;
> + };

2022-04-25 10:05:15

by Krzysztof Kozlowski

Subject: Re: [PATCH v4 3/4] dt-bindings: hwmon: add Microchip LAN966x bindings

On Sun, 24 Apr 2022 at 18:37, Guenter Roeck <[email protected]> wrote:
>
> On 4/1/22 14:40, Michael Walle wrote:
> > Add a binding for the temperature sensor and the fan controller on the
> > Microchip LAN966x family.
> >
> > Signed-off-by: Michael Walle <[email protected]>
> > Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> Still needs approval by a devicetree maintainer.

You already have it :)
https://www.kernel.org/doc/html/latest/process/maintainers.html#open-firmware-and-flattened-device-tree-bindings

Best regards,
Krzysztof

2022-05-03 01:15:45

by Guenter Roeck

Subject: Re: [PATCH v4 3/4] dt-bindings: hwmon: add Microchip LAN966x bindings

On Fri, Apr 01, 2022 at 11:40:31PM +0200, Michael Walle wrote:
> Add a binding for the temperature sensor and the fan controller on the
> Microchip LAN966x family.
>
> Signed-off-by: Michael Walle <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> .../bindings/hwmon/microchip,lan966x.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml b/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
> new file mode 100644
> index 000000000000..390dd6755ff5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,lan966x.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/microchip,lan966x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN966x Hardware Monitor
> +
> +maintainers:
> + - Michael Walle <[email protected]>
> +
> +description: |
> + Microchip LAN966x temperature monitor and fan controller
> +
> +properties:
> + compatible:
> + enum:
> + - microchip,lan9668-hwmon
> +
> + reg:
> + items:
> + - description: PVT registers
> + - description: FAN registers
> +
> + reg-names:
> + items:
> + - const: pvt
> + - const: fan
> +
> + clocks:
> + maxItems: 1
> +
> + '#thermal-sensor-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + hwmon: hwmon@e2010180 {
> + compatible = "microchip,lan9668-hwmon";
> + reg = <0xe2010180 0xc>,
> + <0xe20042a8 0xc>;
> + reg-names = "pvt", "fan";
> + clocks = <&sys_clk>;
> + #thermal-sensor-cells = <0>;
> + };