2022-05-07 19:52:13

by Nícolas F. R. A. Prado

Subject: [PATCH v2] arm64: dts: mt8192: Follow binding order for SCP registers

The dt-binding for SCP documents the reg-names order as sram, cfg,
l1tcm. Update the SCP node on the mt8192 devicetree to follow that
order, which gets rid of a dtbs_check warning. This doesn't change any
behavior since the SCP driver accesses the memory regions through the
names anyway.

Fixes: c63556ec6bfe ("arm64: dts: mt8192: Add SCP node")
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>

---

Changes in v2:
- Added missing Fixes tag

arch/arm64/boot/dts/mediatek/mt8192.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
index 26dbe9ecc528..733aec2e7f77 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
@@ -699,9 +699,9 @@ spi7: spi@1101e000 {
scp: scp@10500000 {
compatible = "mediatek,mt8192-scp";
reg = <0 0x10500000 0 0x100000>,
- <0 0x10700000 0 0x8000>,
- <0 0x10720000 0 0xe0000>;
- reg-names = "sram", "l1tcm", "cfg";
+ <0 0x10720000 0 0xe0000>,
+ <0 0x10700000 0 0x8000>;
+ reg-names = "sram", "cfg", "l1tcm";
interrupts = <GIC_SPI 435 IRQ_TYPE_LEVEL_HIGH 0>;
clocks = <&infracfg CLK_INFRA_SCPSYS>;
clock-names = "main";
--
2.36.0

2022-05-09 09:01:37

by Matthias Brugger

Subject: Re: [PATCH v2] arm64: dts: mt8192: Follow binding order for SCP registers

On 04/05/2022 23:45, Nícolas F. R. A. Prado wrote:
> The dt-binding for SCP documents the reg-names order as sram, cfg,
> l1tcm. Update the SCP node on the mt8192 devicetree to follow that
> order, which gets rid of a dtbs_check warning. This doesn't change any
> behavior since the SCP driver accesses the memory regions through the
> names anyway.
>
> Fixes: c63556ec6bfe ("arm64: dts: mt8192: Add SCP node")
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
>

Applied thanks!

> ---
>
> Changes in v2:
> - Added missing Fixes tag
>
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 26dbe9ecc528..733aec2e7f77 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -699,9 +699,9 @@ spi7: spi@1101e000 {
> scp: scp@10500000 {
> compatible = "mediatek,mt8192-scp";
> reg = <0 0x10500000 0 0x100000>,
> - <0 0x10700000 0 0x8000>,
> - <0 0x10720000 0 0xe0000>;
> - reg-names = "sram", "l1tcm", "cfg";
> + <0 0x10720000 0 0xe0000>,
> + <0 0x10700000 0 0x8000>;
> + reg-names = "sram", "cfg", "l1tcm";
> interrupts = <GIC_SPI 435 IRQ_TYPE_LEVEL_HIGH 0>;
> clocks = <&infracfg CLK_INFRA_SCPSYS>;
> clock-names = "main";