2022-05-10 06:24:54

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] drm/amdgpu: Remove duplicated argument in vcn_v4_0

Fix following coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:724:4-36: duplicated argument to & or |

Remove duplicated UVD_SUVD_CGC_GATE__SRE_H264_MASK.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/Gap/drm/amd/amdgpu/vcn_v4_0.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
index c37dbac9d96b..9119e966ffff 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
@@ -722,7 +722,6 @@ static void vcn_v4_0_disable_clock_gating(struct amdgpu_device *adev, int inst)
| UVD_SUVD_CGC_GATE__SCM_MASK
| UVD_SUVD_CGC_GATE__SDB_MASK
| UVD_SUVD_CGC_GATE__SRE_H264_MASK
- | UVD_SUVD_CGC_GATE__SRE_H264_MASK
| UVD_SUVD_CGC_GATE__SRE_HEVC_MASK
| UVD_SUVD_CGC_GATE__SIT_H264_MASK
| UVD_SUVD_CGC_GATE__SIT_HEVC_MASK
--
2.36.0



2022-05-10 20:37:05

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH] drm/amdgpu: Remove duplicated argument in vcn_v4_0

Applied. Thanks!

Alex

On Mon, May 9, 2022 at 10:50 PM Wan Jiabing <[email protected]> wrote:
>
> Fix following coccicheck warning:
> ./drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:724:4-36: duplicated argument to & or |
>
> Remove duplicated UVD_SUVD_CGC_GATE__SRE_H264_MASK.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/Gap/drm/amd/amdgpu/vcn_v4_0.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index c37dbac9d96b..9119e966ffff 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -722,7 +722,6 @@ static void vcn_v4_0_disable_clock_gating(struct amdgpu_device *adev, int inst)
> | UVD_SUVD_CGC_GATE__SCM_MASK
> | UVD_SUVD_CGC_GATE__SDB_MASK
> | UVD_SUVD_CGC_GATE__SRE_H264_MASK
> - | UVD_SUVD_CGC_GATE__SRE_H264_MASK
> | UVD_SUVD_CGC_GATE__SRE_HEVC_MASK
> | UVD_SUVD_CGC_GATE__SIT_H264_MASK
> | UVD_SUVD_CGC_GATE__SIT_HEVC_MASK
> --
> 2.36.0
>