2022-05-10 13:05:28

by Zheyu Ma

Subject: [PATCH] clk: max9485: Register a callback to disable the regulator

The driver should register a callback which can disable the regulator
when it fails to probe.

Signed-off-by: Zheyu Ma <[email protected]>
---
drivers/clk/clk-max9485.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/clk/clk-max9485.c b/drivers/clk/clk-max9485.c
index 5f85b0a32872..7f521205fd7b 100644
--- a/drivers/clk/clk-max9485.c
+++ b/drivers/clk/clk-max9485.c
@@ -254,6 +254,13 @@ max9485_of_clk_get(struct of_phandle_args *clkspec, void *data)
return &drvdata->hw[idx].hw;
}

+static void max9485_disable_regulator(void *arg)
+{
+ struct max9485_driver_data *drvdata = arg;
+
+ regulator_disable(drvdata->supply);
+}
+
static int max9485_i2c_probe(struct i2c_client *client)
{
struct max9485_driver_data *drvdata;
@@ -279,6 +286,10 @@ static int max9485_i2c_probe(struct i2c_client *client)
if (ret < 0)
return ret;

+ ret = devm_add_action_or_reset(dev, max9485_disable_regulator, drvdata->supply);
+ if (ret)
+ return ret;
+
drvdata->reset_gpio =
devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(drvdata->reset_gpio))
--
2.25.1

2022-08-15 20:00:05

by Stephen Boyd

Subject: Re: [PATCH] clk: max9485: Register a callback to disable the regulator

Quoting Zheyu Ma (2022-05-10 01:43:15)
> The driver should register a callback which can disable the regulator
> when it fails to probe.
>
> Signed-off-by: Zheyu Ma <[email protected]>
> ---

Looks like there's going to be a devm_regulator_get_enable() API that
we can use instead. Please do that.

https://lore.kernel.org/all/[email protected]/