2022-05-11 04:25:21

by Zheyu Ma

Subject: [PATCH] media: TDA1997x: Fix the error handling in tda1997x_probe()

The driver should disable the regulator when failing to probe.

Signed-off-by: Zheyu Ma <[email protected]>
---
drivers/media/i2c/tda1997x.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
index 8fafce26d62f..0de7acdf58a7 100644
--- a/drivers/media/i2c/tda1997x.c
+++ b/drivers/media/i2c/tda1997x.c
@@ -2798,6 +2798,7 @@ static int tda1997x_probe(struct i2c_client *client,
cancel_delayed_work(&state->delayed_work_enable_hpd);
mutex_destroy(&state->page_lock);
mutex_destroy(&state->lock);
+ tda1997x_set_power(state, 0);
err_free_state:
kfree(state);
dev_err(&client->dev, "%s failed: %d\n", __func__, ret);
--
2.25.1

2022-05-14 00:38:23

by Tim Harvey

Subject: Re: [PATCH] media: TDA1997x: Fix the error handling in tda1997x_probe()

On Tue, May 10, 2022 at 6:42 AM Zheyu Ma <[email protected]> wrote:
>
> The driver should disable the regulator when failing to probe.
>
> Signed-off-by: Zheyu Ma <[email protected]>
> ---
> drivers/media/i2c/tda1997x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
> index 8fafce26d62f..0de7acdf58a7 100644
> --- a/drivers/media/i2c/tda1997x.c
> +++ b/drivers/media/i2c/tda1997x.c
> @@ -2798,6 +2798,7 @@ static int tda1997x_probe(struct i2c_client *client,
> cancel_delayed_work(&state->delayed_work_enable_hpd);
> mutex_destroy(&state->page_lock);
> mutex_destroy(&state->lock);
> + tda1997x_set_power(state, 0);
> err_free_state:
> kfree(state);
> dev_err(&client->dev, "%s failed: %d\n", __func__, ret);
> --
> 2.25.1
>

Acked-By: Tim Harvey <[email protected]>

Best Regards,

Tim