2022-05-10 18:25:55

by Chukun Pan

Subject: [PATCH v2 0/1] arm64: dts: allwinner: h6: Enable CPU opp tables for OrangePi One Plus

Changes from v2:
* Remove regulator-enable-ramp-delay for cpu and gpu.

Chukun Pan (1):
arm64: dts: allwinner: h6: Enable CPU opp tables for OrangePi One Plus

arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

--
2.25.1

2022-05-10 19:44:14

by Chukun Pan

Subject: [PATCH v2 1/1] arm64: dts: allwinner: h6: Enable CPU opp tables for OrangePi One Plus

Enable CPU opp tables for OrangePi One Plus.

This needs to change the CPU regulator max voltage to fit
the OPP table.

Signed-off-by: Chukun Pan <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
index 92745128fcfe..7773c51438ce 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
@@ -5,6 +5,7 @@
/dts-v1/;

#include "sun50i-h6.dtsi"
+#include "sun50i-h6-cpu-opp.dtsi"

#include <dt-bindings/gpio/gpio.h>

@@ -64,6 +65,10 @@ reg_vcc5v: vcc5v {
};
};

+&cpu0 {
+ cpu-supply = <&reg_dcdca>;
+};
+
&de {
status = "okay";
};
@@ -208,7 +213,7 @@ reg_cldo3: cldo3 {
reg_dcdca: dcdca {
regulator-always-on;
regulator-min-microvolt = <810000>;
- regulator-max-microvolt = <1080000>;
+ regulator-max-microvolt = <1160000>;
regulator-name = "vdd-cpu";
};

--
2.25.1

2022-07-05 06:03:07

by Samuel Holland

Subject: Re: [PATCH v2 1/1] arm64: dts: allwinner: h6: Enable CPU opp tables for OrangePi One Plus

On 5/10/22 10:30 AM, Chukun Pan wrote:
> Enable CPU opp tables for OrangePi One Plus.
>
> This needs to change the CPU regulator max voltage to fit
> the OPP table.
>
> Signed-off-by: Chukun Pan <[email protected]>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> index 92745128fcfe..7773c51438ce 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi

Putting the changes in this file also applies them to the OrangePi Lite2 and
OrangePi 3.

Did you test OrangePi Lite2? They both use the same PMIC with a similar
configuration, so it may be safe to assume that what works on OrangePi One Plus
also works there, but I am not sure.

OrangePi 3 already includes the OPP header and these changes, so it is safe but
redundant.

Either these changes need to be made in sun50i-h6-orangepi-one-plus.dts, or we
need to remove the duplicate changes from sun50i-h6-orangepi-3.dts.

Regards,
Samuel

> @@ -5,6 +5,7 @@
> /dts-v1/;
>
> #include "sun50i-h6.dtsi"
> +#include "sun50i-h6-cpu-opp.dtsi"
>
> #include <dt-bindings/gpio/gpio.h>
>
> @@ -64,6 +65,10 @@ reg_vcc5v: vcc5v {
> };
> };
>
> +&cpu0 {
> + cpu-supply = <&reg_dcdca>;
> +};
> +
> &de {
> status = "okay";
> };
> @@ -208,7 +213,7 @@ reg_cldo3: cldo3 {
> reg_dcdca: dcdca {
> regulator-always-on;
> regulator-min-microvolt = <810000>;
> - regulator-max-microvolt = <1080000>;
> + regulator-max-microvolt = <1160000>;
> regulator-name = "vdd-cpu";
> };
>
>