2022-05-11 09:32:06

by Yuan Can

Subject: [PATCH] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram

The hw_srnprot needs to be unmapped when gamecube_rtc_read_offset_from_sram returns.

Fixs: 86559400b3ef9d (rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U)
Signed-off-by: Yuan Can <[email protected]>
---
drivers/rtc/rtc-gamecube.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/rtc-gamecube.c b/drivers/rtc/rtc-gamecube.c
index 18ca3b38b2d0..c2717bb52b2b 100644
--- a/drivers/rtc/rtc-gamecube.c
+++ b/drivers/rtc/rtc-gamecube.c
@@ -267,6 +267,7 @@ static int gamecube_rtc_read_offset_from_sram(struct priv *d)
ret = regmap_read(d->regmap, RTC_SRAM_BIAS, &d->rtc_bias);
if (ret) {
pr_err("failed to get the RTC bias\n");
+ iounmap(hw_srnprot);
return -1;
}

--
2.17.1

2022-05-18 13:26:41

by Alexandre Belloni

Subject: Re: [PATCH] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram

On Wed, 11 May 2022 07:13:54 +0000, Yuan Can wrote:
> The hw_srnprot needs to be unmapped when gamecube_rtc_read_offset_from_sram returns.
>
>

Applied, thanks!

[1/1] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram
commit: 6ddabcb106280db0f7344850adfce3dd6b171cbd

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com