[Why]
The DC_DEFAULT_LOG_MASK macro has not been used for a long time, so remove it.
Signed-off-by: pengfuyuan <[email protected]>
---
.../drm/amd/display/include/logger_types.h | 33 -------------------
1 file changed, 33 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h b/drivers/gpu/drm/amd/display/include/logger_types.h
index f093b49c5e6e..1b38cfc41718 100644
--- a/drivers/gpu/drm/amd/display/include/logger_types.h
+++ b/drivers/gpu/drm/amd/display/include/logger_types.h
@@ -131,37 +131,4 @@ enum dc_log_type {
#define DC_MIN_LOG_MASK ((1 << LOG_ERROR) | \
(1 << LOG_DETECTION_EDID_PARSER))
-#define DC_DEFAULT_LOG_MASK ((1ULL << LOG_ERROR) | \
- (1ULL << LOG_WARNING) | \
- (1ULL << LOG_EVENT_MODE_SET) | \
- (1ULL << LOG_EVENT_DETECTION) | \
- (1ULL << LOG_EVENT_LINK_TRAINING) | \
- (1ULL << LOG_EVENT_LINK_LOSS) | \
- (1ULL << LOG_EVENT_UNDERFLOW) | \
- (1ULL << LOG_RESOURCE) | \
- (1ULL << LOG_FEATURE_OVERRIDE) | \
- (1ULL << LOG_DETECTION_EDID_PARSER) | \
- (1ULL << LOG_DC) | \
- (1ULL << LOG_HW_HOTPLUG) | \
- (1ULL << LOG_HW_SET_MODE) | \
- (1ULL << LOG_HW_RESUME_S3) | \
- (1ULL << LOG_HW_HPD_IRQ) | \
- (1ULL << LOG_SYNC) | \
- (1ULL << LOG_BANDWIDTH_VALIDATION) | \
- (1ULL << LOG_MST) | \
- (1ULL << LOG_DETECTION_DP_CAPS) | \
- (1ULL << LOG_BACKLIGHT)) | \
- (1ULL << LOG_I2C_AUX) | \
- (1ULL << LOG_IF_TRACE) | \
- (1ULL << LOG_HDMI_FRL) | \
- (1ULL << LOG_SCALER) | \
- (1ULL << LOG_DTN) /* | \
- (1ULL << LOG_DEBUG) | \
- (1ULL << LOG_BIOS) | \
- (1ULL << LOG_SURFACE) | \
- (1ULL << LOG_DML) | \
- (1ULL << LOG_HW_LINK_TRAINING) | \
- (1ULL << LOG_HW_AUDIO)| \
- (1ULL << LOG_BANDWIDTH_CALCS)*/
-
#endif /* __DAL_LOGGER_TYPES_H__ */
--
2.25.1
Hi pengfuyuan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v5.18-rc6 next-20220512]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/pengfuyuan/drm-amd-display-Remove-macro-DC_DEFAULT_LOG_MASK/20220512-185320
base: git://anongit.freedesktop.org/drm/drm drm-next
config: arm-randconfig-r016-20220512 (https://download.01.org/0day-ci/archive/20220513/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 9519dacab7b8afd537811fc2abaceb4d14f4e16a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/intel-lab-lkp/linux/commit/94b3092ea272cf77105cc7b19fcffc44b49e1a71
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review pengfuyuan/drm-amd-display-Remove-macro-DC_DEFAULT_LOG_MASK/20220512-185320
git checkout 94b3092ea272cf77105cc7b19fcffc44b49e1a71
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:30:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:30:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:40:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw_sequencer.h:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/clock_source.h:31:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/bios_parser_types.h:30:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:35:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dmub/dmub_srv.h:67:
drivers/gpu/drm/amd/amdgpu/../display/dmub/inc/dmub_cmd.h:862:18: warning: field cursor_copy_src within 'struct dmub_rb_cmd_mall' is less aligned than 'union dmub_addr' and is usually due to 'struct dmub_rb_cmd_mall' being packed, which can lead to unaligned accesses [-Wunaligned-access]
union dmub_addr cursor_copy_src; /**< Cursor copy address */
^
drivers/gpu/drm/amd/amdgpu/../display/dmub/inc/dmub_cmd.h:863:18: warning: field cursor_copy_dst within 'struct dmub_rb_cmd_mall' is less aligned than 'union dmub_addr' and is usually due to 'struct dmub_rb_cmd_mall' being packed, which can lead to unaligned accesses [-Wunaligned-access]
union dmub_addr cursor_copy_dst; /**< Cursor copy destination */
^
2 warnings and 2 errors generated.
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_irq.c:27:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_irq.c:27:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:40:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw_sequencer.h:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/clock_source.h:31:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/bios_parser_types.h:30:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
2 errors generated.
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
1 error generated.
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:28:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:30:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_helpers.h:34:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:3685:25: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
enum act_return_status ret;
^
1 warning and 2 errors generated.
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:28:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:30:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/resource.h:28:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1642:6: warning: no previous prototype for function 'is_timing_changed' [-Wmissing-prototypes]
bool is_timing_changed(struct dc_stream_state *cur_stream,
^
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1642:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
bool is_timing_changed(struct dc_stream_state *cur_stream,
^
static
1 warning and 2 errors generated.
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:25:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/link_enc_cfg.h:33:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:25:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/link_enc_cfg.h:33:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:40:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw_sequencer.h:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/clock_source.h:31:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/bios_parser_types.h:30:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:570:6: warning: variable 'matching_stream_ptrs' set but not used [-Wunused-but-set-variable]
int matching_stream_ptrs = 0;
^
1 warning and 2 errors generated.
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:28:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36:
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
In file included from drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:29:
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26:2: error: unterminated conditional directive
#ifndef __DAL_LOGGER_TYPES_H__
^
drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:1179:15: warning: variable 'average_render_time_in_us' set but not used [-Wunused-but-set-variable]
unsigned int average_render_time_in_us = 0;
^
1 warning and 2 errors generated.
vim +26 drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h
4562236b3bc0a28 Harry Wentland 2017-09-12 @26 #ifndef __DAL_LOGGER_TYPES_H__
4562236b3bc0a28 Harry Wentland 2017-09-12 27 #define __DAL_LOGGER_TYPES_H__
4562236b3bc0a28 Harry Wentland 2017-09-12 28
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Hi pengfuyuan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v5.18-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/pengfuyuan/drm-amd-display-Remove-macro-DC_DEFAULT_LOG_MASK/20220512-185320
base: git://anongit.freedesktop.org/drm/drm drm-next
config: powerpc64-randconfig-s032-20220512 (https://download.01.org/0day-ci/archive/20220513/[email protected]/config)
compiler: powerpc64-linux-gcc (GCC) 11.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/intel-lab-lkp/linux/commit/94b3092ea272cf77105cc7b19fcffc44b49e1a71
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review pengfuyuan/drm-amd-display-Remove-macro-DC_DEFAULT_LOG_MASK/20220512-185320
git checkout 94b3092ea272cf77105cc7b19fcffc44b49e1a71
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:30:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/include/bios_parser_types.h:30,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/clock_source.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw_sequencer.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:40,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:30:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/link_enc_cfg.h:33,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:32:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:131:22: warning: 'SYNAPTICS_DEVICE_ID' defined but not used [-Wunused-const-variable=]
131 | static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:128:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=]
128 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:127:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=]
127 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_irq.c:27:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/include/bios_parser_types.h:30,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/clock_source.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw_sequencer.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:40,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_irq.c:27:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_trace.h:40,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_trace.h:24,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:27:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/include/bios_parser_types.h:30,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/clock_source.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw_sequencer.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:40,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_trace.h:40,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_trace.h:24,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:27:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c: In function 'dc_fpu_begin':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:97:25: error: implicit declaration of function 'enable_kernel_altivec'; did you mean 'enable_kernel_vsx'? [-Werror=implicit-function-declaration]
97 | enable_kernel_altivec();
| ^~~~~~~~~~~~~~~~~~~~~
| enable_kernel_vsx
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c: In function 'dc_fpu_end':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:133:25: error: implicit declaration of function 'disable_kernel_altivec'; did you mean 'disable_kernel_vsx'? [-Werror=implicit-function-declaration]
133 | disable_kernel_altivec();
| ^~~~~~~~~~~~~~~~~~~~~~
| disable_kernel_vsx
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_trace.h:40,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_trace.h:24,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/dc_fpu.c:27:
At top level:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:131:22: warning: 'SYNAPTICS_DEVICE_ID' defined but not used [-Wunused-const-variable=]
131 | static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:128:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=]
128 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:127:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=]
127 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:34:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:36:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:42:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:128:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=]
128 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:127:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=]
127 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:29:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/../display_mode_lib.h:28,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c:26:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c: In function 'dml20_ModeSupportAndSystemConfigurationFull':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c:3900:72: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
3900 | locals->ODMCombineEnablePerState[i][k] = false;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c:3904:88: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
3904 | locals->ODMCombineEnablePerState[i][k] = true;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c:3907:88: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
3907 | locals->ODMCombineEnablePerState[i][k] = true;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c:3960:80: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
3960 | locals->ODMCombineEnablePerState[i][k] = false;
| ^
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/../display_mode_lib.h:28,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20v2.c:26:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20v2.c: In function 'dml20v2_ModeSupportAndSystemConfigurationFull':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20v2.c:4011:72: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4011 | locals->ODMCombineEnablePerState[i][k] = false;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20v2.c:4015:88: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4015 | locals->ODMCombineEnablePerState[i][k] = true;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20v2.c:4018:88: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4018 | locals->ODMCombineEnablePerState[i][k] = true;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20v2.c:4021:88: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4021 | locals->ODMCombineEnablePerState[i][k] = true;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20v2.c:4074:80: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4074 | locals->ODMCombineEnablePerState[i][k] = false;
| ^
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/../display_mode_lib.h:28,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:27:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c: In function 'dml21_ModeSupportAndSystemConfigurationFull':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:4103:72: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4103 | locals->ODMCombineEnablePerState[i][k] = false;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:4107:88: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4107 | locals->ODMCombineEnablePerState[i][k] = true;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:4110:88: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4110 | locals->ODMCombineEnablePerState[i][k] = true;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:4113:88: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4113 | locals->ODMCombineEnablePerState[i][k] = true;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:4166:80: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
4166 | locals->ODMCombineEnablePerState[i][k] = false;
| ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:5231:60: warning: implicit conversion from 'enum <anonymous>' to 'enum odm_combine_mode' [-Wenum-conversion]
5231 | mode_lib->vba.ODMCombineEnabled[k] = false;
| ^
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:27:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/include/bios_parser_types.h:30,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/clock_source.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw_sequencer.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:40,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:27:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c: In function 'DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerformanceCalculation':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:3055:24: warning: variable 'MaxUsedBW' set but not used [-Wunused-but-set-variable]
3055 | double MaxUsedBW = 0;
| ^~~~~~~~~
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.c:27:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/include/bios_parser_types.h:30,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/clock_source.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw_sequencer.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:40,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.c:27:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.c:41:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
from drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.c:27:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:131:22: warning: 'SYNAPTICS_DEVICE_ID' defined but not used [-Wunused-const-variable=]
131 | static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:128:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=]
128 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:127:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=]
127 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/gpu/drm/amd/amdgpu/../display/include/logger_interface.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:36,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:28:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc.h:31,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:32:
>> drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h:26: error: unterminated #ifndef
26 | #ifndef __DAL_LOGGER_TYPES_H__
|
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c: In function 'dcn3_get_pix_clk_dividers':
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:1258:32: warning: variable 'clk_src' set but not used [-Wunused-but-set-variable]
1258 | struct dce110_clk_src *clk_src;
| ^~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:32:
At top level:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:131:22: warning: 'SYNAPTICS_DEVICE_ID' defined but not used [-Wunused-const-variable=]
131 | static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:128:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=]
128 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:127:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=]
127 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
..
vim +26 drivers/gpu/drm/amd/amdgpu/../display/include/logger_types.h
4562236b3bc0a2 Harry Wentland 2017-09-12 @26 #ifndef __DAL_LOGGER_TYPES_H__
4562236b3bc0a2 Harry Wentland 2017-09-12 27 #define __DAL_LOGGER_TYPES_H__
4562236b3bc0a2 Harry Wentland 2017-09-12 28
--
0-DAY CI Kernel Test Service
https://01.org/lkp
On Fri, May 13, 2022 at 3:20 AM pengfuyuan <[email protected]> wrote:
>
> [Why]
> The DC_DEFAULT_LOG_MASK macro has not been used for a long time, so remove it.
I'm sure there are lots of macros in the driver that are not used at
the moment. Any particular reason to remove it? DC_MIN_LOG_MASK
doesn't appear to be used at the moment either.
Alex
>
> Signed-off-by: pengfuyuan <[email protected]>
> ---
> .../drm/amd/display/include/logger_types.h | 33 -------------------
> 1 file changed, 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h b/drivers/gpu/drm/amd/display/include/logger_types.h
> index f093b49c5e6e..1b38cfc41718 100644
> --- a/drivers/gpu/drm/amd/display/include/logger_types.h
> +++ b/drivers/gpu/drm/amd/display/include/logger_types.h
> @@ -131,37 +131,4 @@ enum dc_log_type {
> #define DC_MIN_LOG_MASK ((1 << LOG_ERROR) | \
> (1 << LOG_DETECTION_EDID_PARSER))
>
> -#define DC_DEFAULT_LOG_MASK ((1ULL << LOG_ERROR) | \
> - (1ULL << LOG_WARNING) | \
> - (1ULL << LOG_EVENT_MODE_SET) | \
> - (1ULL << LOG_EVENT_DETECTION) | \
> - (1ULL << LOG_EVENT_LINK_TRAINING) | \
> - (1ULL << LOG_EVENT_LINK_LOSS) | \
> - (1ULL << LOG_EVENT_UNDERFLOW) | \
> - (1ULL << LOG_RESOURCE) | \
> - (1ULL << LOG_FEATURE_OVERRIDE) | \
> - (1ULL << LOG_DETECTION_EDID_PARSER) | \
> - (1ULL << LOG_DC) | \
> - (1ULL << LOG_HW_HOTPLUG) | \
> - (1ULL << LOG_HW_SET_MODE) | \
> - (1ULL << LOG_HW_RESUME_S3) | \
> - (1ULL << LOG_HW_HPD_IRQ) | \
> - (1ULL << LOG_SYNC) | \
> - (1ULL << LOG_BANDWIDTH_VALIDATION) | \
> - (1ULL << LOG_MST) | \
> - (1ULL << LOG_DETECTION_DP_CAPS) | \
> - (1ULL << LOG_BACKLIGHT)) | \
> - (1ULL << LOG_I2C_AUX) | \
> - (1ULL << LOG_IF_TRACE) | \
> - (1ULL << LOG_HDMI_FRL) | \
> - (1ULL << LOG_SCALER) | \
> - (1ULL << LOG_DTN) /* | \
> - (1ULL << LOG_DEBUG) | \
> - (1ULL << LOG_BIOS) | \
> - (1ULL << LOG_SURFACE) | \
> - (1ULL << LOG_DML) | \
> - (1ULL << LOG_HW_LINK_TRAINING) | \
> - (1ULL << LOG_HW_AUDIO)| \
> - (1ULL << LOG_BANDWIDTH_CALCS)*/
> -
> #endif /* __DAL_LOGGER_TYPES_H__ */
> --
> 2.25.1
>