2022-05-16 13:48:56

by Stefan Berzl

[permalink] [raw]
Subject: Re: Status on hid xppen patch

Yo José,

>>> I had to introduce new functionalities to the templating system of the
>>> driver, that's the reason for the KUnit tests.
>>> The last patch is work in progress (hopefully I'll have time to finish
>>> it this weekend), only the HID descriptors are missing.
>>
>> I hope you make it, but otherwise you can always use mine, as it's quite
>> the same as yours. Only the logical minimum and maximum are -60 and 60.
>
> You are right, 60 and not 127 is the right value. Actually, I think
> that -61 - 60 is the correct range, because of the 0.
> Running "libinput-debug-tablet" makes it easier to debug.
>
> I also had to fix the descriptor to avoid an issue with the pressure
> causing issues with the Deco L, but other than that, it should be
> correct now.

I don't think the two's complement thing has any bearing here, because
there are still several numbers left in both directions. Also I couldn't
get the mini 7 to produce tilt values either >60 or <-60,
but I'm sure you'll get behind it.

> Also, I don't know if you have seen this error after connecting the
> tablet:
>
> xhci_hcd 0000:2a:00.3: WARN urb submitted to disabled ep
> usb 3-2: reset full-speed USB device number 6 using xhci_hcd
> usb 3-2: reset full-speed USB device number 6 using xhci_hcd
> [...]
>
> It happens with the Deco Mini 4, even when using the hid-generic
> driver. I need to rebase my patches on 5.19 and test again, just to
> make sure the problem is not somewhere else.

Can't say I have seen it. The only thing I can think of is that I was
using the async urb functions and that delay did something about it.

Kind regards

Stefan Berzl


2022-05-17 02:01:48

by José Expósito

[permalink] [raw]
Subject: Re: Status on hid xppen patch

On Mon, May 16, 2022 at 12:45:48PM +0200, Stefan Berzl wrote:
> Yo Jos?,
>
> > Also, I don't know if you have seen this error after connecting the
> > tablet:
> >
> > xhci_hcd 0000:2a:00.3: WARN urb submitted to disabled ep
> > usb 3-2: reset full-speed USB device number 6 using xhci_hcd
> > usb 3-2: reset full-speed USB device number 6 using xhci_hcd
> > [...]
> >
> > It happens with the Deco Mini 4, even when using the hid-generic
> > driver. I need to rebase my patches on 5.19 and test again, just to
> > make sure the problem is not somewhere else.
>
> Can't say I have seen it. The only thing I can think of is that I was
> using the async urb functions and that delay did something about it.

Thanks, I'll give it a try. I hope is not some kind of time based
condition.

By the way, I only see the error when the tablet is connected. If I run
"usbhid-dump" or unload and load the driver, it works as expected.
I don't know if this could be related to the driver failing to process
the response to the magic data... Investigating.

Thanks,
Jose