2022-05-23 14:55:41

by Miaoqian Lin

Subject: [PATCH] ARM: exynos: Fix refcount leak in exynos_map_pmu

of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
of_node_put() checks null pointer.

Fixes: fce9e5bb2526 ("ARM: EXYNOS: Add support for mapping PMU base address via DT")
Signed-off-by: Miaoqian Lin <[email protected]>
---
arch/arm/mach-exynos/exynos.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 8b48326be9fd..51a247ca4da8 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -149,6 +149,7 @@ static void exynos_map_pmu(void)
np = of_find_matching_node(NULL, exynos_dt_pmu_match);
if (np)
pmu_base_addr = of_iomap(np, 0);
+ of_node_put(np);
}

static void __init exynos_init_irq(void)
--
2.25.1

2022-06-06 09:45:43

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: exynos: Fix refcount leak in exynos_map_pmu

On Mon, 23 May 2022 18:55:13 +0400, Miaoqian Lin wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
> of_node_put() checks null pointer.
>
>

Applied, thanks!

[1/1] ARM: exynos: Fix refcount leak in exynos_map_pmu
https://git.kernel.org/krzk/linux/c/c4c79525042a4a7df96b73477feaf232fe44ae81

Best regards,
--
Krzysztof Kozlowski <[email protected]>