2022-05-24 10:25:09

by Jiapeng Chong

Subject: [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info static

This symbol is not used outside of amdgpu_discovery.c, so marks it static.

Fixes the following w1 warning:

drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
previous prototype for ‘amdgpu_discovery_get_mall_info’
[-Wmissing-prototypes].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 881570dced41..16cdfb30b013 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -1361,7 +1361,7 @@ union mall_info {
struct mall_info_v1_0 v1;
};

-int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
+static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
{
struct binary_header *bhdr;
union mall_info *mall_info;
--
2.20.1.7.g153144c

2022-05-26 12:09:03

by Luben Tuikov

Subject: Re: [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info static

This is already static, in our local branch, from this commit:

commit 6852e61a0917a2
Author: Evan Quan <[email protected]>
Date: Thu May 19 17:28:12 2022 +0800

drm/amdgpu: suppress some compile warnings

Suppress two compile warnings about "no previous prototype".

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Evan Quan <[email protected]>
Reviewed-by: Alex Deucher <[email protected]>

Regards,
Luben


On 2022-05-24 04:11, Jiapeng Chong wrote:
> This symbol is not used outside of amdgpu_discovery.c, so marks it static.
>
> Fixes the following w1 warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
> previous prototype for ‘amdgpu_discovery_get_mall_info’
> [-Wmissing-prototypes].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 881570dced41..16cdfb30b013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -1361,7 +1361,7 @@ union mall_info {
> struct mall_info_v1_0 v1;
> };
>
> -int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
> +static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
> {
> struct binary_header *bhdr;
> union mall_info *mall_info;

Regards,
--
Luben