2022-05-22 19:43:12

by Gautam Menghani

Subject: [PATCH] kernel/trace: Initialize integer variable to prevent garbage return value

Initialize the integer variable to 0 to fix the clang scan warning:
Undefined or garbage value returned to caller
[core.uninitialized.UndefReturn]
return ret;

Signed-off-by: Gautam Menghani <[email protected]>
---
kernel/trace/trace_boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
index 0580287d7a0d..778200dd8ede 100644
--- a/kernel/trace/trace_boot.c
+++ b/kernel/trace/trace_boot.c
@@ -300,7 +300,7 @@ trace_boot_hist_add_handlers(struct xbc_node *hnode, char **bufp,
{
struct xbc_node *node;
const char *p, *handler;
- int ret;
+ int ret = 0;

handler = xbc_node_get_data(hnode);

--
2.25.1

2022-05-26 03:00:25

by Steven Rostedt

Subject: Re: [PATCH] kernel/trace: Initialize integer variable to prevent garbage return value

On Sat, 21 May 2022 23:18:26 -0700
Gautam Menghani <[email protected]> wrote:

> Initialize the integer variable to 0 to fix the clang scan warning:
> Undefined or garbage value returned to caller
> [core.uninitialized.UndefReturn]
> return ret;
>
> Signed-off-by: Gautam Menghani <[email protected]>
> ---
> kernel/trace/trace_boot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> index 0580287d7a0d..778200dd8ede 100644
> --- a/kernel/trace/trace_boot.c
> +++ b/kernel/trace/trace_boot.c
> @@ -300,7 +300,7 @@ trace_boot_hist_add_handlers(struct xbc_node *hnode, char **bufp,
> {
> struct xbc_node *node;
> const char *p, *handler;
> - int ret;
> + int ret = 0;

Looks good to me. Masami, care to ack it?

-- Steve

>
> handler = xbc_node_get_data(hnode);
>

2022-05-26 20:43:16

by Masami Hiramatsu

Subject: Re: [PATCH] kernel/trace: Initialize integer variable to prevent garbage return value

On Wed, 25 May 2022 11:25:51 -0400
Steven Rostedt <[email protected]> wrote:

> On Sat, 21 May 2022 23:18:26 -0700
> Gautam Menghani <[email protected]> wrote:
>
> > Initialize the integer variable to 0 to fix the clang scan warning:
> > Undefined or garbage value returned to caller
> > [core.uninitialized.UndefReturn]
> > return ret;
> >
> > Signed-off-by: Gautam Menghani <[email protected]>
> > ---
> > kernel/trace/trace_boot.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> > index 0580287d7a0d..778200dd8ede 100644
> > --- a/kernel/trace/trace_boot.c
> > +++ b/kernel/trace/trace_boot.c
> > @@ -300,7 +300,7 @@ trace_boot_hist_add_handlers(struct xbc_node *hnode, char **bufp,
> > {
> > struct xbc_node *node;
> > const char *p, *handler;
> > - int ret;
> > + int ret = 0;
>
> Looks good to me. Masami, care to ack it?

Thanks! This looks good to me.

Fixes: 8993665abcce ("tracing/boot: Support multiple handlers for per-event histogram")
Cc: [email protected]
Acked-by: Masami Hiramatsu (Google) <[email protected]>

Thank you!

>
> -- Steve
>
> >
> > handler = xbc_node_get_data(hnode);
> >
>


--
Masami Hiramatsu (Google) <[email protected]>