2022-06-01 12:34:22

by Miaoqian Lin

Subject: [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps

of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
Signed-off-by: Miaoqian Lin <[email protected]>
---
drivers/mfd/max77620.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
index fec2096474ad..a6661e07035b 100644
--- a/drivers/mfd/max77620.c
+++ b/drivers/mfd/max77620.c
@@ -419,9 +419,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip)
ret = max77620_config_fps(chip, fps_child);
if (ret < 0) {
of_node_put(fps_child);
+ of_node_put(fps_np);
return ret;
}
}
+ of_node_put(fps_np);

config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0;
ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2,
--
2.25.1

2022-06-01 19:43:57

by Krzysztof Kozlowski

Subject: Re: [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps

On 01/06/2022 06:32, Miaoqian Lin wrote:
> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
> Signed-off-by: Miaoqian Lin <[email protected]>

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-06-15 22:05:01

by Lee Jones

Subject: Re: [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps

On Wed, 01 Jun 2022, Miaoqian Lin wrote:

> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
> Signed-off-by: Miaoqian Lin <[email protected]>
> ---
> drivers/mfd/max77620.c | 2 ++
> 1 file changed, 2 insertions(+)

Applied, thanks.

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog