2022-06-07 11:02:12

by Li kunyu

Subject: [PATCH] arm: create_mapping function to remove unused return values

Change the return value to void to reduce eax register execution.

Signed-off-by: Li kunyu <[email protected]>
---
arch/arm/mm/kasan_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c
index 5ad0d6c56d56..db2068329985 100644
--- a/arch/arm/mm/kasan_init.c
+++ b/arch/arm/mm/kasan_init.c
@@ -187,7 +187,7 @@ static void __init clear_pgds(unsigned long start,
pmd_clear(pmd_off_k(start));
}

-static int __init create_mapping(void *start, void *end)
+static void __init create_mapping(void *start, void *end)
{
void *shadow_start, *shadow_end;

@@ -199,7 +199,6 @@ static int __init create_mapping(void *start, void *end)

kasan_pgd_populate((unsigned long)shadow_start & PAGE_MASK,
PAGE_ALIGN((unsigned long)shadow_end), false);
- return 0;
}

void __init kasan_init(void)
--
2.18.2

2022-06-09 19:42:50

by Andrey Konovalov

Subject: Re: [PATCH] arm: create_mapping function to remove unused return values

On Tue, Jun 7, 2022 at 5:31 AM Li kunyu <[email protected]> wrote:
>
> Change the return value to void to reduce eax register execution.
>
> Signed-off-by: Li kunyu <[email protected]>
> ---
> arch/arm/mm/kasan_init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c
> index 5ad0d6c56d56..db2068329985 100644
> --- a/arch/arm/mm/kasan_init.c
> +++ b/arch/arm/mm/kasan_init.c
> @@ -187,7 +187,7 @@ static void __init clear_pgds(unsigned long start,
> pmd_clear(pmd_off_k(start));
> }
>
> -static int __init create_mapping(void *start, void *end)
> +static void __init create_mapping(void *start, void *end)
> {
> void *shadow_start, *shadow_end;
>
> @@ -199,7 +199,6 @@ static int __init create_mapping(void *start, void *end)
>
> kasan_pgd_populate((unsigned long)shadow_start & PAGE_MASK,
> PAGE_ALIGN((unsigned long)shadow_end), false);
> - return 0;
> }
>
> void __init kasan_init(void)
> --
> 2.18.2

Reviewed-by: Andrey Konovalov <[email protected]>