2022-06-12 23:26:43

by Armin Wolf

[permalink] [raw]
Subject: [PATCH] hwmon: (dell-smm) Add Dell G5 5590 to DMI table

According to Bug 215983 at bugzilla.kernel.org,
the Dell G5 5590 supports the SMM interface and
can thus be loaded with ignore_dmi being set.
Add the model the DMI table to allow for
automatic loadig on this model.

Compile-tested only.

Signed-off-by: Armin Wolf <[email protected]>
---
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 16c10ac84a91..d419885dd771 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1131,6 +1131,13 @@ static const struct i8k_config_data i8k_config_data[] __initconst = {
};

static const struct dmi_system_id i8k_dmi_table[] __initconst = {
+ {
+ .ident = "Dell G5 5590",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G5 5590"),
+ },
+ },
{
.ident = "Dell Inspiron",
.matches = {
--
2.30.2


2022-06-13 08:28:32

by Pali Rohár

[permalink] [raw]
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell G5 5590 to DMI table

On Monday 13 June 2022 01:22:08 Armin Wolf wrote:
> According to Bug 215983 at bugzilla.kernel.org,
> the Dell G5 5590 supports the SMM interface and
> can thus be loaded with ignore_dmi being set.
> Add the model the DMI table to allow for
> automatic loadig on this model.
>
> Compile-tested only.
>
> Signed-off-by: Armin Wolf <[email protected]>

Acked-by: Pali Rohár <[email protected]>

> ---
> drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 16c10ac84a91..d419885dd771 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1131,6 +1131,13 @@ static const struct i8k_config_data i8k_config_data[] __initconst = {
> };
>
> static const struct dmi_system_id i8k_dmi_table[] __initconst = {
> + {
> + .ident = "Dell G5 5590",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G5 5590"),
> + },
> + },
> {
> .ident = "Dell Inspiron",
> .matches = {
> --
> 2.30.2
>

2022-06-13 17:24:42

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell G5 5590 to DMI table

On Mon, Jun 13, 2022 at 01:22:08AM +0200, Armin Wolf wrote:
> According to Bug 215983 at bugzilla.kernel.org,
> the Dell G5 5590 supports the SMM interface and
> can thus be loaded with ignore_dmi being set.
> Add the model the DMI table to allow for
> automatic loadig on this model.
>
> Compile-tested only.
>
> Signed-off-by: Armin Wolf <[email protected]>
> Acked-by: Pali Roh?r <[email protected]>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --
> 2.30.2
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 16c10ac84a91..d419885dd771 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1131,6 +1131,13 @@ static const struct i8k_config_data i8k_config_data[] __initconst = {
> };
>
> static const struct dmi_system_id i8k_dmi_table[] __initconst = {
> + {
> + .ident = "Dell G5 5590",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G5 5590"),
> + },
> + },
> {
> .ident = "Dell Inspiron",
> .matches = {