2022-06-13 06:38:11

by Muchun Song

Subject: [PATCH 5/6] mm: hugetlb_vmemmap: replace early_param() with core_param()

After the following commit and previous commit applied.

78f39084b41d ("mm: hugetlb_vmemmap: add hugetlb_optimize_vmemmap sysctl")

There is no order requirement between the parameter of "hugetlb_free_vmemmap"
and "hugepages" since we have removed the check of whether HVO is enabled
from hugetlb_vmemmap_init(). Therefore we can safely replace early_param()
with core_param() to simplify the code.

Signed-off-by: Muchun Song <[email protected]>
---
mm/hugetlb_vmemmap.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
index abdf441215bb..9808d32cdb9e 100644
--- a/mm/hugetlb_vmemmap.c
+++ b/mm/hugetlb_vmemmap.c
@@ -415,14 +415,8 @@ static int vmemmap_remap_alloc(unsigned long start, unsigned long end,
DEFINE_STATIC_KEY_FALSE(hugetlb_optimize_vmemmap_key);
EXPORT_SYMBOL(hugetlb_optimize_vmemmap_key);

-static bool vmemmap_optimize_enabled =
- IS_ENABLED(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON);
-
-static int __init hugetlb_vmemmap_early_param(char *buf)
-{
- return kstrtobool(buf, &vmemmap_optimize_enabled);
-}
-early_param("hugetlb_free_vmemmap", hugetlb_vmemmap_early_param);
+static bool vmemmap_optimize_enabled = IS_ENABLED(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON);
+core_param(hugetlb_free_vmemmap, vmemmap_optimize_enabled, bool, 0);

/*
* Previously discarded vmemmap pages will be allocated and remapping
--
2.11.0

2022-06-13 22:46:55

by Mike Kravetz

Subject: Re: [PATCH 5/6] mm: hugetlb_vmemmap: replace early_param() with core_param()

On Mon, Jun 13, 2022 at 02:35:11PM +0800”, Muchun Song wrote:
> After the following commit and previous commit applied.
>
> 78f39084b41d ("mm: hugetlb_vmemmap: add hugetlb_optimize_vmemmap sysctl")
>
> There is no order requirement between the parameter of "hugetlb_free_vmemmap"
> and "hugepages" since we have removed the check of whether HVO is enabled
> from hugetlb_vmemmap_init(). Therefore we can safely replace early_param()
> with core_param() to simplify the code.
>
> Signed-off-by: Muchun Song <[email protected]>
> ---
> mm/hugetlb_vmemmap.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)

Reviewed-by: Mike Kravetz <[email protected]>

--
Mike Kravetz