2022-06-13 07:59:17

by Ilpo Järvinen

Subject: [PATCH 1/2] serial: 8250: Use UART_LCR_WLEN8 instead of literal

Use UART_LCR_WLEN8 instead of literal 0x03 in size_fifo().

Signed-off-by: Ilpo Järvinen <[email protected]>
---
drivers/tty/serial/8250/8250_port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 953b0fadfd4c..8365c7ad3576 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -843,7 +843,7 @@ static int size_fifo(struct uart_8250_port *up)
serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
old_dl = serial_dl_read(up);
serial_dl_write(up, 0x0001);
- serial_out(up, UART_LCR, 0x03);
+ serial_out(up, UART_LCR, UART_LCR_WLEN8);
for (count = 0; count < 256; count++)
serial_out(up, UART_TX, count);
mdelay(20);/* FIXME - schedule_timeout */
--
2.30.2

2022-06-13 08:01:45

by Ilpo Järvinen

Subject: [PATCH 2/2] serial: 8250_pericom: Use UART_LCR_DLAB

Use UART_LCR_DLAB instead of literal.

Signed-off-by: Ilpo Järvinen <[email protected]>
---
drivers/tty/serial/8250/8250_pericom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_pericom.c b/drivers/tty/serial/8250/8250_pericom.c
index 95ff10f25d58..b8d5b7714a9d 100644
--- a/drivers/tty/serial/8250/8250_pericom.c
+++ b/drivers/tty/serial/8250/8250_pericom.c
@@ -73,7 +73,7 @@ static void pericom_do_set_divisor(struct uart_port *port, unsigned int baud,
struct uart_8250_port *up = up_to_u8250p(port);
int lcr = serial_port_in(port, UART_LCR);

- serial_port_out(port, UART_LCR, lcr | 0x80);
+ serial_port_out(port, UART_LCR, lcr | UART_LCR_DLAB);
serial_dl_write(up, divisor);
serial_port_out(port, 2, 16 - scr);
serial_port_out(port, UART_LCR, lcr);
--
2.30.2

2022-06-13 09:02:17

by Jiri Slaby

Subject: Re: [PATCH 2/2] serial: 8250_pericom: Use UART_LCR_DLAB

On 13. 06. 22, 9:57, Ilpo Järvinen wrote:
> Use UART_LCR_DLAB instead of literal.
>
> Signed-off-by: Ilpo Järvinen <[email protected]>

Reviewed-by: Jiri Slaby <[email protected]>

> ---
> drivers/tty/serial/8250/8250_pericom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pericom.c b/drivers/tty/serial/8250/8250_pericom.c
> index 95ff10f25d58..b8d5b7714a9d 100644
> --- a/drivers/tty/serial/8250/8250_pericom.c
> +++ b/drivers/tty/serial/8250/8250_pericom.c
> @@ -73,7 +73,7 @@ static void pericom_do_set_divisor(struct uart_port *port, unsigned int baud,
> struct uart_8250_port *up = up_to_u8250p(port);
> int lcr = serial_port_in(port, UART_LCR);
>
> - serial_port_out(port, UART_LCR, lcr | 0x80);
> + serial_port_out(port, UART_LCR, lcr | UART_LCR_DLAB);
> serial_dl_write(up, divisor);
> serial_port_out(port, 2, 16 - scr);
> serial_port_out(port, UART_LCR, lcr);


--
js
suse labs

2022-06-13 09:03:09

by Jiri Slaby

Subject: Re: [PATCH 1/2] serial: 8250: Use UART_LCR_WLEN8 instead of literal

On 13. 06. 22, 9:57, Ilpo Järvinen wrote:
> Use UART_LCR_WLEN8 instead of literal 0x03 in size_fifo().
>
> Signed-off-by: Ilpo Järvinen <[email protected]>

Reviewed-by: Jiri Slaby <[email protected]>

> ---
> drivers/tty/serial/8250/8250_port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index 953b0fadfd4c..8365c7ad3576 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -843,7 +843,7 @@ static int size_fifo(struct uart_8250_port *up)
> serial_out(up, UART_LCR, UART_LCR_CONF_MODE_A);
> old_dl = serial_dl_read(up);
> serial_dl_write(up, 0x0001);
> - serial_out(up, UART_LCR, 0x03);
> + serial_out(up, UART_LCR, UART_LCR_WLEN8);
> for (count = 0; count < 256; count++)
> serial_out(up, UART_TX, count);
> mdelay(20);/* FIXME - schedule_timeout */


--
js
suse labs