2022-06-19 07:50:31

by Liang He

Subject: [PATCH] powerpc: kernel: Fix refcount bug in legacy_serial.c

In find_legacy_serial_ports(), of_find_node_by_path() will return
a node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.

Signed-off-by: Liang He <[email protected]>
---
arch/powerpc/kernel/legacy_serial.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c
index 5c58460b269a..f048c424c525 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -471,6 +471,8 @@ void __init find_legacy_serial_ports(void)
}
#endif

+ of_node_put(stdout);
+
DBG("legacy_serial_console = %d\n", legacy_serial_console);
if (legacy_serial_console >= 0)
setup_legacy_serial_console(legacy_serial_console);
--
2.25.1

2022-09-09 12:49:01

by Michael Ellerman

Subject: Re: [PATCH] powerpc: kernel: Fix refcount bug in legacy_serial.c

On Sun, 19 Jun 2022 15:08:11 +0800, Liang He wrote:
> In find_legacy_serial_ports(), of_find_node_by_path() will return
> a node pointer with refcount incremented. We should use of_node_put()
> when it is not used anymore.
>
>

Applied to powerpc/next.

[1/1] powerpc: kernel: Fix refcount bug in legacy_serial.c
https://git.kernel.org/powerpc/c/d1aabbbb2564f23b66ded10d870e7859e92075a3

cheers