2022-06-21 07:01:11

by Jiang Jian

[permalink] [raw]
Subject: [PATCH] iio: aligned '*' each line

Consider '*' alignment in comments

Signed-off-by: Jiang Jian <[email protected]>
---
drivers/iio/dac/ad5380.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
index a44c83242fb1..f8291cb013ce 100644
--- a/drivers/iio/dac/ad5380.c
+++ b/drivers/iio/dac/ad5380.c
@@ -36,7 +36,7 @@
* @channel_template: channel specification template
* @num_channels: number of channels
* @int_vref: internal vref in uV
-*/
+ */

struct ad5380_chip_info {
struct iio_chan_spec channel_template;
--
2.17.1


2022-06-21 08:58:47

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] iio: aligned '*' each line

On Tue, Jun 21, 2022 at 8:57 AM Jiang Jian <[email protected]> wrote:
>
> Consider '*' alignment in comments

Subject should start with "iio: dac: ad5380: ..."

The commit message should follow English grammar (missed period in
your case) and explain a little bit more, e.g. "Consider '*' alignment
in the comments of struct ad5380_chip_info declaration".

...

> * @channel_template: channel specification template
> * @num_channels: number of channels
> * @int_vref: internal vref in uV
> -*/
> + */
>

While at it, drop the unneeded blank line here.

> struct ad5380_chip_info {


--
With Best Regards,
Andy Shevchenko