2022-06-21 16:42:23

by Jiang Jian

[permalink] [raw]
Subject: [PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places.

file: ./arch/mips/sgi-ip22/ip22-gio.c
line: 44
* @ids: array of of device match structures to search in
changed to
* @ids: array of device match structures to search in

Signed-off-by: Jiang Jian <[email protected]>
---
arch/mips/sgi-ip22/ip22-gio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c
index 38d12f417e48..03d96638f957 100644
--- a/arch/mips/sgi-ip22/ip22-gio.c
+++ b/arch/mips/sgi-ip22/ip22-gio.c
@@ -41,7 +41,7 @@ static struct device gio_bus = {
/**
* gio_match_device - Tell if an of_device structure has a matching
* gio_match structure
- * @ids: array of of device match structures to search in
+ * @ids: array of device match structures to search in
* @dev: the of device structure to match against
*
* Used by a driver to check whether an of_device present in the
--
2.17.1


2022-06-21 20:00:24

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH] mips: sgi-ip22: Remove duplicate 'of' in two places.

The Subject speaks about two places, there is only one change here
however?

On Wed, Jun 22, 2022 at 12:21:14AM +0800, Jiang Jian wrote:
> file: ./arch/mips/sgi-ip22/ip22-gio.c
> line: 44
> * @ids: array of of device match structures to search in
> changed to
> * @ids: array of device match structures to search in

I know writing a sensible commit log is hard, but this is really very
useless. This is a plain repetition of the diff below.

Additionally I'm not sure the patch is right. The comment speaks about
of (= open firmware) devices. So if you want to improve here, maybe make
it read

+ * @match: array gio_device_id structures to search in

But please double check this is indeed sensible; I didn't.

(But yes, @ids is wrong, the parameter is named match.)

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (975.00 B)
signature.asc (499.00 B)
Download all attachments